Skip to content

Commit

Permalink
Re-enable tests for multiple linters (#3756)
Browse files Browse the repository at this point in the history
Failing test is no longer able to repro locally.

For #2571
  • Loading branch information
d3r3kk authored Dec 20, 2018
1 parent 1406dac commit a139248
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/test/linters/lint.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { IProductPathService, IProductService } from '../../client/common/instal
import { IConfigurationService, IOutputChannel, ProductType } from '../../client/common/types';
import { LinterManager } from '../../client/linters/linterManager';
import { ILinterManager, ILintMessage, LintMessageSeverity } from '../../client/linters/types';
import { IS_TRAVIS } from '../ciConstants';
import { deleteFile, PythonSettingKeys, rootWorkspaceUri } from '../common';
import { closeActiveWindows, initialize, initializeTest, IS_MULTI_ROOT_TEST } from '../initialize';
import { MockOutputChannel } from '../mockClasses';
Expand Down Expand Up @@ -269,11 +270,15 @@ suite('Linting - General Tests', () => {
await configService.updateSetting('linting.pylintUseMinimalCheckers', false, workspaceUri);
await testEnablingDisablingOfLinter(Product.pylint, true, file);
});
// tslint:disable-next-line:no-function-expression
test('Multiple linters', async function () {
// skip this unreliable test: gh 2571 tracking this issue...
// tslint:disable-next-line:no-invalid-this
return this.skip();
// travis times out with the 25sec limit, but is also going to be retired
// in the near future in favour of Azure DevOps pipelines. Since Azure DevOps
// seem to not timeout (at least as much), skip this test in Travis.
if (IS_TRAVIS) {
// tslint:disable-next-line:no-invalid-this
return this.skip();
}

await closeActiveWindows();
const document = await workspace.openTextDocument(path.join(pythoFilesPath, 'print.py'));
await window.showTextDocument(document);
Expand Down

0 comments on commit a139248

Please sign in to comment.