Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify on missing kernel and interpreter with kernel #10508

Merged
merged 1 commit into from
Mar 10, 2020
Merged

notify on missing kernel and interpreter with kernel #10508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/client/datascience/jupyter/kernels/kernelSelector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,21 @@ export class KernelSelector {
kernelSpec = await this.kernelService.findMatchingKernelSpec(interpreter, session, cancelToken);

if (kernelSpec) {
traceVerbose(`ipykernel installed in ${interpreter.path}, and matching found.`);
traceVerbose(`ipykernel installed in ${interpreter.path}, and matching kernelspec found.`);
// Make sure the environment matches.
await this.kernelService.updateKernelEnvironment(interpreter, kernelSpec, cancelToken);

// Notify the UI that we didn't find the initially requested kernel and are just using the active interpreter
if (displayNameOfKernelNotFound && !disableUI) {
this.applicationShell
.showInformationMessage(
localize.DataScience.fallbackToUseActiveInterpeterAsKernel().format(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message already existed and was in unit tests, but not in the product at all. Might have gotten factored out?

displayNameOfKernelNotFound
)
)
.then(noop, noop);
}

sendTelemetryEvent(Telemetry.UseInterpreterAsKernel);
return { kernelSpec, interpreter };
}
Expand Down