Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datascience to datascience_modules (#10525) #10528

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 11, 2020

* Rename datascience to datascience_modules

* Change name to something even harder to get wrong
@rchiodo rchiodo self-assigned this Mar 11, 2020
@rchiodo rchiodo added the no-changelog No news entry required label Mar 11, 2020
@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #10528 into release-2020.03 will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.03   #10528      +/-   ##
===================================================
- Coverage            60.86%   60.84%   -0.03%     
===================================================
  Files                  579      579              
  Lines                31290    31291       +1     
  Branches              4449     4450       +1     
===================================================
- Hits                 19045    19039       -6     
- Misses               11282    11287       +5     
- Partials               963      965       +2
Impacted Files Coverage Δ
.../datascience/jupyter/interpreter/jupyterCommand.ts 55.17% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterVariables.ts 50.57% <0%> (ø) ⬆️
src/client/datascience/constants.ts 99.71% <100%> (ø) ⬆️
...er/jupyterInterpreterSubCommandExecutionService.ts 83.33% <100%> (ø) ⬆️
...reter/jupyterCommandInterpreterExecutionService.ts 68.88% <100%> (ø) ⬆️
src/client/common/process/pythonDaemonPool.ts 70.58% <100%> (ø) ⬆️
src/client/constants.ts 83.33% <0%> (-16.67%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2603a...737f2a7. Read the comment docs.

@rchiodo rchiodo closed this Mar 12, 2020
@rchiodo rchiodo reopened this Mar 12, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@rchiodo rchiodo merged commit f7cf79b into release-2020.03 Mar 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
@rchiodo rchiodo deleted the rchiodo/port_ds_rename branch April 22, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants