Ensure isolate script is passed as command arg when installing modules #11447
Conversation
karthiknadig
force-pushed
the
issue11399
branch
from
6cefa01 to
c41a92e
Compare
| return processService | ||
| .exec(options.command, pyArgs.concat(args), {}) | ||
| .exec(options.command, pyArgs, {}) |
There was a problem hiding this comment.
This is a minor convenience change to help with debugging
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #11447 +/- ##
==========================================
- Coverage 61.03% 61.01% -0.03%
==========================================
Files 613 613
Lines 33630 33631 +1
Branches 4751 4751
==========================================
- Hits 20527 20520 -7
+ Misses 12657 12079 -578
- Partials 446 1032 +586
Continue to review full report at Codecov.
|
| @@ -45,7 +45,7 @@ export abstract class ModuleInstaller implements IModuleInstaller { | |||
| ? await interpreterService.getActiveInterpreter(resource) | |||
| : resource; | |||
| const pythonPath = isResource(resource) ? settings.pythonPath : resource.path; | |||
| const args = internalPython.execModule(executionInfo.moduleName, executionInfoArgs); | |||
| const args = internalPython.execModule(executionInfo.moduleName, executionInfoArgs, true, true); | |||
There was a problem hiding this comment.
It's very easy to forget which boolean is which in calls like that. I know there's no named arguments in TS, but is there any other idiom that might make it more readable?
There was a problem hiding this comment.
I agree. @kimadeline any recommendations?
There was a problem hiding this comment.
The only thing I can think of would be to use an options object, but it's not TS-specific. Seems to be a JS thing though. I remember talking about it with somebody on the team, can't remember who it was 😬
I actually use an options object in my pipenv PR, and my threshold was 2 booleans.
What do you think?
There was a problem hiding this comment.
I will update this in my next PR for this area.
…g modules (microsoft#11447)" This reverts commit b2a0b59.
For #11399
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).