Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed property name used to capture the trigger source of Unit Tests. #1214

Merged

Conversation

DonJayamanne
Copy link

Fixes #1213

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #1214 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   71.91%   71.98%   +0.06%     
==========================================
  Files         260      260              
  Lines       11933    11933              
  Branches     2121     2121              
==========================================
+ Hits         8582     8590       +8     
+ Misses       3221     3217       -4     
+ Partials      130      126       -4
Impacted Files Coverage Δ
...lient/unittests/common/managers/baseTestManager.ts 77.5% <ø> (ø) ⬆️
src/client/debugger/Main.ts 50.61% <0%> (+0.49%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (+0.65%) ⬆️
src/client/debugger/PythonProcess.ts 47.08% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99171f...9d283df. Read the comment docs.

@DonJayamanne DonJayamanne merged commit d1eb8e9 into microsoft:master Mar 27, 2018
@DonJayamanne DonJayamanne deleted the issue1213UnitTestTelemetry branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change telemetry event for running Unit tests
2 participants