Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory class to create the process service #1342

Merged
merged 15 commits into from
May 8, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 8, 2018

Fixes #1339

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #1342 into master will increase coverage by 0.31%.
The diff coverage is 85.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   71.35%   71.67%   +0.31%     
==========================================
  Files         274      277       +3     
  Lines       12733    12816      +83     
  Branches     2286     2299      +13     
==========================================
+ Hits         9086     9186     +100     
+ Misses       3507     3496      -11     
+ Partials      140      134       -6
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/common/configSettings.ts 87.95% <ø> (ø) ⬆️
src/client/common/process/types.ts 100% <100%> (ø) ⬆️
...t/common/variables/environmentVariablesProvider.ts 100% <100%> (ø) ⬆️
src/client/common/process/proc.ts 100% <100%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 100% <100%> (ø) ⬆️
...ent/interpreter/display/shebangCodeLensProvider.ts 100% <100%> (ø) ⬆️
src/client/sortImports.ts 71.42% <100%> (-2.77%) ⬇️
...ient/interpreter/locators/services/condaService.ts 97.39% <100%> (+0.09%) ⬆️
...ent/interpreter/locators/services/pipEnvService.ts 95.52% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96eb9a...f383281. Read the comment docs.

@DonJayamanne DonJayamanne changed the title WIP - Add factory class to create the process service Add factory class to create the process service May 8, 2018
@DonJayamanne DonJayamanne merged commit 128d231 into microsoft:master May 8, 2018
@DonJayamanne DonJayamanne deleted the issue1339 branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProcessService needs to be modified to use resolved environment variables
2 participants