Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of "master" #13646

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Conversation

brettcannon
Copy link
Member

Left usage in src/datascience-ui/data-explorer/testData.ts as that's historical data from (I believe) the Titanic's traveller manifest.

This should not be merged until the actual renaming occurs.

Part of #13645

Left usage in testData.ts for data science as that's historical data from (I believe) the Titanic's traveler manifest.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main September 3, 2020 21:06
@brettcannon brettcannon marked this pull request as ready for review September 3, 2020 21:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #13646 into main will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13646      +/-   ##
==========================================
+ Coverage   59.71%   59.89%   +0.17%     
==========================================
  Files         673      682       +9     
  Lines       37658    37935     +277     
  Branches     5402     5462      +60     
==========================================
+ Hits        22488    22721     +233     
- Misses      14017    14038      +21     
- Partials     1153     1176      +23     
Impacted Files Coverage Δ
src/client/common/experiments/manager.ts 96.00% <100.00%> (ø)
src/client/datascience/kernel-launcher/helpers.ts 14.28% <0.00%> (-42.86%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-14.59%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 71.71% <0.00%> (-1.82%) ⬇️
...s/discovery/locators/services/KnownPathsService.ts 48.21% <0.00%> (-1.79%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/datascience/jupyter/kernels/helpers.ts 34.86% <0.00%> (-0.66%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2b333...af0d765. Read the comment docs.

@brettcannon brettcannon merged commit fb797a3 into microsoft:main Sep 3, 2020
@brettcannon brettcannon deleted the master-to-main branch September 3, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants