Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies LS startup and update test baselines #1762

Merged
merged 90 commits into from
May 29, 2018
Merged

Simplifies LS startup and update test baselines #1762

merged 90 commits into from
May 29, 2018

Conversation

MikhailArkhipov
Copy link

Reflects changes to the analysis engine

This pull request:

  • Has a title summarizes what is changing
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #1762 into master will increase coverage by 0.15%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   73.94%   74.09%   +0.15%     
==========================================
  Files         282      282              
  Lines       13117    13095      -22     
  Branches     2338     2338              
==========================================
+ Hits         9699     9703       +4     
+ Misses       3287     3260      -27     
- Partials      131      132       +1
Impacted Files Coverage Δ
src/client/activation/analysis.ts 18.91% <11.11%> (+2.37%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/mainV2.ts 80.72% <0%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f295f47...2edeb3c. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit 9b7ebf6 into microsoft:master May 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants