Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added system tests to check activation for virtual environments #3592

Merged
merged 36 commits into from
Dec 28, 2018
Merged

Added system tests to check activation for virtual environments #3592

merged 36 commits into from
Dec 28, 2018

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Dec 7, 2018 •
edited
Loading

For #1521 #1522 #1523 and Create system test to check activation of venv

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

DonJayamanne
DonJayamanne requested changes Dec 7, 2018
View reviewed changes
src/test/unittests/terminalActivation.test-virtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
src/testVirtualEnv/envPaths.json Outdated Show resolved Hide resolved
@DonJayamanne DonJayamanne changed the title Added system tests to check activation for virtual environments WIP - Added system tests to check activation for virtual environments Dec 7, 2018
DonJayamanne
DonJayamanne requested changes Dec 7, 2018
View reviewed changes
src/test/unittests/terminalActivation.testvirtualenvs.ts Outdated Show resolved Hide resolved
build/ci/vscode-python-pr-validation.yaml Outdated Show resolved Hide resolved
build/ci/vscode-python-pr-validation.yaml Show resolved Hide resolved
build/ci/templates/virtual_env_tests.yml Outdated Show resolved Hide resolved
build/ci/templates/virtual_env_tests.yml Outdated Show resolved Hide resolved
build/ci/templates/virtual_env_tests.yml Outdated Show resolved Hide resolved
DonJayamanne
DonJayamanne previously requested changes Dec 7, 2018
View reviewed changes
build/ci/templates/virtual_env_tests.yml Outdated Show resolved Hide resolved
build/ci/vscode-python-pr-validation.yaml Outdated Show resolved Hide resolved
@karrtikr karrtikr force-pushed the add_venv_tests branch 2 times, most recently from 061bc9f to 54e1293 Compare December 8, 2018 02:16
@karrtikr karrtikr force-pushed the add_venv_tests branch 3 times, most recently from 4469a47 to 4cff223 Compare December 9, 2018 01:04
@karrtikr karrtikr force-pushed the add_venv_tests branch 2 times, most recently from f0236c3 to 917038c Compare December 10, 2018 18:54
@karrtikr karrtikr force-pushed the add_venv_tests branch 3 times, most recently from bd83abf to fe9355e Compare December 10, 2018 21:03
@karrtikr karrtikr changed the title WIP - Added system tests to check activation for virtual environments Added system tests to check activation for virtual environments Dec 11, 2018
@karrtikr karrtikr force-pushed the add_venv_tests branch 4 times, most recently from dd68299 to e351f1f Compare December 18, 2018 20:08
@karrtikr karrtikr force-pushed the add_venv_tests branch 2 times, most recently from 56ae86a to 077ca12 Compare December 19, 2018 22:40
@karrtikr karrtikr changed the title WIP - Added system tests to check activation for virtual environments Added system tests to check activation for virtual environments Dec 19, 2018
@karrtikr karrtikr merged commit facaaed into master Dec 28, 2018
@karrtikr karrtikr deleted the add_venv_tests branch January 1, 2019 00:27
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrtikr @DonJayamanne @d3r3kk