New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDefaultOptions refactoring #3712

Closed

nullie wants to merge 1 commit into microsoft:master from nullie:get_default_options_refactoring

nullie commented Dec 15, 2018

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
~~Has a news entry file (remember to thank yourself!)~~
~~Unit tests & system/integration tests are added/updated~~
~~Test plan is updated as appropriate~~
~~package-lock.json has been regenerated by running npm install (if dependencies have changed)~~

brettcannon added the external contributor label

brettcannon closed this

brettcannon reopened this


          getDefaultOptions refactoring

74cea09

nullie force-pushed the get_default_options_refactoring branch from 5b5f104 to 74cea09 Compare

December 21, 2018 07:27

DonJayamanne commented Dec 21, 2018

Thanks for the PR, however this doesn't resolve #2571.

DonJayamanne closed this

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet