Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Activation of multiple parts of the extension for multiple workspaces #4040

Closed
wants to merge 2 commits into from
Closed

WIP - Activation of multiple parts of the extension for multiple workspaces #4040

wants to merge 2 commits into from

Conversation

DonJayamanne
Copy link

For #3502
Part 4 of #3502

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne requested a review from karrtikr January 17, 2019 21:47
karrtikr
karrtikr suggested changes Jan 18, 2019
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonJayamanne Can you please force push into this branch and update it?

@DonJayamanne
Copy link
Author

@karrtikr Done, all yours.

@karrtikr karrtikr mentioned this pull request Jan 18, 2019
Merged
8 tasks
@DonJayamanne
Copy link
Author

Closing in favor of #4052

@DonJayamanne DonJayamanne deleted the issue3502Part4 branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karrtikr karrtikr karrtikr requested changes

Assignees

@karrtikr karrtikr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @karrtikr