Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change names of telemetry properties captured during load of ext #4113

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

DonJayamanne
Copy link

For #3901
Change names of telemetry properties, original properties seem to be have suppressed.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #4113 into master will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4113   +/-   ##
======================================
+ Coverage      79%     79%   +1%     
======================================
  Files         407     408    +1     
  Lines       18677   18768   +91     
  Branches     3013    3033   +20     
======================================
+ Hits        14645   14724   +79     
- Misses       4029    4041   +12     
  Partials        3       3
Flag Coverage Δ
#Linux 68% <ø> (+1%) ⬆️
#Windows 69% <ø> (+1%) ⬆️
#macOS 68% <ø> (+1%) ⬆️

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 23, 2019
@DonJayamanne DonJayamanne merged commit 7921cac into microsoft:master Jan 24, 2019
DonJayamanne added a commit that referenced this pull request Jan 25, 2019
For #3901
Change names of telemetry properties, original properties seem to be have suppressed.
@DonJayamanne DonJayamanne deleted the fixTelemetryProps branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants