Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep testing configuration alive after losing focus #4316

Conversation

ericsnowcurrently
Copy link
Member

(for #4288)

Note that I changed a few places to use IApplicationShell instead of vscode.window. This isn't strictly related to the PR (I thought it was at first), but it's not a big addition so I'd rather just leave it. If there are any objections then I don't mind dropping that part (i.e. the "Use IApplicationShell instead of vscode.window." commit below).

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #4316 into master will increase coverage by 23%.
The diff coverage is 25%.

@@           Coverage Diff            @@
##           master   #4316     +/-   ##
========================================
+ Coverage      57%     79%    +23%     
========================================
  Files         348     422     +74     
  Lines       14566   19363   +4797     
  Branches     2252    3112    +860     
========================================
+ Hits         8263   15257   +6994     
+ Misses       5774    4103   -1671     
+ Partials      529       3    -526
Flag Coverage Δ
#Linux 68% <25%> (?)
#Windows 69% <25%> (?)
#macOS 68% <25%> (?)

@ericsnowcurrently ericsnowcurrently merged commit 8635eda into microsoft:master Feb 7, 2019
@ericsnowcurrently ericsnowcurrently deleted the config-keep-alive-no-focus branch February 7, 2019 20:06
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants