Add more logging around jupyter server death #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle security issue for WS
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
=======================================
- Coverage 77% 77% -<1%
=======================================
Files 446 446
Lines 21151 21226 +75
Branches 3456 3473 +17
=======================================
+ Hits 16264 16303 +39
- Misses 4883 4919 +36
Partials 4 4
|
| @@ -247,7 +263,7 @@ export class JupyterServerBase implements INotebookServer { | |||
|
|
|||
| // Complete all pending as an error. We're restarting | |||
| const copyPending = [...this.pendingCellSubscriptions]; | |||
| copyPending.forEach(c => c.reject()); | |||
| copyPending.forEach(c => c.reject(new Error('Restarting kernel'))); | |||
There was a problem hiding this comment.
I might just be following the promise / deferred chain wrong. But is this shown in the UI?
There was a problem hiding this comment.
Ah, I forgot to remove these. These should have been empty still.
In reply to: 263191091 [](ancestors = 263191091)
There was a problem hiding this comment.
Sounds good. The rest of it looks good to me.
In reply to: 263191335 [](ancestors = 263191335,263191091)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4573, #4497
Add more logging around server death and connection problems. Make kernel spec connection problems not cause server crash
Also adjust the version of 'ws' in use.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)