-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex to dedent else
and friends
#6497
Conversation
else
and friends
Going through Python's grammar, here is the thinking: Dedent the following line after the statement
return [ # Does the following line still get indented (which is what we want)? Indent the the following line after the statement
Dedent the statement line itself while still indenting the following line
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Everything looks correct. I just have a few comments relative to helping out readers.
Co-Authored-By: Eric Snow <[email protected]>
Co-Authored-By: Eric Snow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For #6333
else
(andelif
while we're at it)indentationRules
keypackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)