Renamed pep8 to pycodestyle

[marsfan]

For #410

Not 100% sure if this passes CI checks (my computer was a bit finicky with unit tests), but I am setting up the PR now to trigger the CI system and see if everything looks good.

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
• Title summarizes what is changing
• Has a news entry file (remember to thank yourself!)
• Appropriate comments and documentation strings in the code
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated
• Test plan is updated as appropriate
• package-lock.json has been regenerated by running npm install (if dependencies have changed)
• The wiki is updated with any design decisions/details.

[msftclas]

All CLA requirements met.

[marsfan]

It seems all the tests passed. Something must have been configured wrong on my end.

[DonJayamanne]

Thanks for the PR, awesome work.
A few changes:

• Please do not deprecate the old setting (just remove it).
• We'll need to migrate existing users from the old setting to the new (see https://github.com/microsoft/vscode-python/blob/master/src/client/testing/common/updateTestSettings.ts, we've done this in the past).

[marsfan]

@DonJayamanne I do not have any experience with typescript, but I'll see what I can do.

Should I be adding these new checks to the same file, or creating a new one?

[marsfan]

Just pushed a new commit. I added into the same file support for renaming the settings.

[DonJayamanne]

do not have any experience with typescript, but I'll see what I can do.

That's fine, we can do that work. Thank for your awesome work.

[marsfan]

@DonJayamanne @ericsnowcurrently I have not heard anything about this in a while. Anything I need to do?

[codecov-io]

Codecov Report

Merging #6570 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6570      +/-   ##
==========================================
- Coverage   58.48%   58.44%   -0.04%     
==========================================
  Files         485      485              
  Lines       21437    21446       +9     
  Branches     3462     3462              
==========================================
- Hits        12537    12535       -2     
- Misses       8122     8135      +13     
+ Partials      778      776       -2

Impacted Files	Coverage Δ
src/client/linters/constants.ts	100% <ø> (ø)	⬆️
src/client/linters/types.ts	100% <ø> (ø)	⬆️
src/client/linters/pycodestyle.ts	100% <100%> (ø)
src/client/linters/linterManager.ts	72.6% <100%> (ø)	⬆️
src/client/common/installer/productNames.ts	100% <100%> (ø)	⬆️
src/client/common/configSettings.ts	57.54% <100%> (ø)	⬆️
src/client/common/installer/productInstaller.ts	77.24% <100%> (ø)	⬆️
src/client/testing/common/updateTestSettings.ts	96.42% <100%> (+0.68%)	⬆️
src/client/common/installer/productService.ts	100% <100%> (ø)	⬆️
src/client/common/types.ts	100% <100%> (ø)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a55af...77417b3. Read the comment docs.

[ericsnowcurrently]

LGTM

out-of-date