Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logging support for python debug adapter #8272

Merged
merged 8 commits into from
Oct 31, 2019

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 29, 2019

For #8106

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated

@kimadeline I need some advise on testing the logger.

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #8272 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8272      +/-   ##
==========================================
+ Coverage   59.33%   59.38%   +0.05%     
==========================================
  Files         504      505       +1     
  Lines       23096    23126      +30     
  Branches     3737     3740       +3     
==========================================
+ Hits        13704    13734      +30     
  Misses       8500     8500              
  Partials      892      892
Impacted Files Coverage Δ
src/client/debugger/extension/serviceRegistry.ts 100% <100%> (ø) ⬆️
src/client/debugger/extension/adapter/activator.ts 100% <100%> (ø) ⬆️
src/client/debugger/extension/types.ts 100% <100%> (ø) ⬆️
src/client/debugger/extension/adapter/logging.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796f843...75e4b23. Read the comment docs.

@karthiknadig
Copy link
Member Author

@DonJayamanne I need some advise on testing DebugSessionLoggingTracker. I feel like the right way to test it would be to use an end to end test.

@karthiknadig karthiknadig force-pushed the dalogging branch 2 times, most recently from e7e6b80 to 4942ecb Compare October 30, 2019 05:14
@karthiknadig karthiknadig marked this pull request as ready for review October 30, 2019 18:50
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typescript suggestions but other than it looks good to me 👍

src/client/debugger/extension/adapter/logging.ts Outdated Show resolved Hide resolved
src/client/debugger/extension/adapter/logging.ts Outdated Show resolved Hide resolved
src/client/debugger/extension/adapter/logging.ts Outdated Show resolved Hide resolved
src/test/debugger/extension/adapter/logging.unit.test.ts Outdated Show resolved Hide resolved
@karthiknadig karthiknadig merged commit 81a2af6 into microsoft:master Oct 31, 2019
@karthiknadig karthiknadig deleted the dalogging branch November 1, 2019 17:26
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants