Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind function to class instance in middleware #9109

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Bind function to class instance in middleware #9109

merged 2 commits into from
Dec 16, 2019

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Dec 13, 2019

For #9096
Haven't found tests for this specific class.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
    - [ ] Has sufficient logging.
    - [ ] Has telemetry for enhancements.
    - [ ] Unit tests & system/integration tests are added/updated
    - [ ] Test plan is updated as appropriate
    - [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
    - [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #9109 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9109      +/-   ##
==========================================
- Coverage   57.11%   57.07%   -0.05%     
==========================================
  Files         551      551              
  Lines       29144    29176      +32     
  Branches     4404     4414      +10     
==========================================
+ Hits        16646    16652       +6     
- Misses      11592    11614      +22     
- Partials      906      910       +4
Impacted Files Coverage Δ
...ivation/languageServer/languageClientMiddleware.ts 8.1% <100%> (+1.25%) ⬆️
...ient/datascience/jupyter/kernels/kernelSelector.ts 78.94% <0%> (-8.01%) ⬇️
...nt/datascience/jupyter/kernels/kernelSelections.ts 92.64% <0%> (-1.01%) ⬇️
...lient/datascience/jupyter/jupyterSessionManager.ts 9.75% <0%> (-0.78%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 6.62% <0%> (-0.15%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 18.32% <0%> (-0.03%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 53.84% <0%> (ø) ⬆️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/datascience/jupyter/notebookStarter.ts 71.54% <0%> (+0.57%) ⬆️
src/datascience-ui/react-common/postOffice.ts 4.68% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844a423...29318b9. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit 7167439 into microsoft:master Dec 16, 2019
@MikhailArkhipov MikhailArkhipov deleted the middleware branch December 16, 2019 17:49
@lock lock bot locked as resolved and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants