Revert calling mypy with relatives paths (regression) #9502
+6
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1b6fbfb.
karrtikr
approved these changes
Jan 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #9502 +/- ##
==========================================
- Coverage 60.88% 60.85% -0.04%
==========================================
Files 530 530
Lines 28631 28648 +17
Branches 4340 4345 +5
==========================================
Hits 17433 17433
- Misses 10245 10258 +13
- Partials 953 957 +4
Continue to review full report at Codecov.
|
This reverts commit c634ffd.
|
Kudos, SonarCloud Quality Gate passed!
|
kimadeline
added a commit
to kimadeline/vscode-python
that referenced
this pull request
Jan 10, 2020
* Revert "fix(client/linters/mypy): call mypy incorrectly (microsoft#5834)" This reverts commit 1b6fbfb. * News file * Revert "Fix MyPy CI tests (microsoft#8518)" This reverts commit c634ffd.
kimadeline
added a commit
that referenced
this pull request
Jan 10, 2020
* Revert calling mypy with relatives paths (regression) (#9502) * Revert "fix(client/linters/mypy): call mypy incorrectly (#5834)" This reverts commit 1b6fbfb. * News file * Revert "Fix MyPy CI tests (#8518)" This reverts commit c634ffd. * Disable conda execution service instantiation (#9493) * Disable conda execution service instantiation * News file * Didn't mean to commit that * Forgot a few tests * Linting * Update comment * Linting * Test failure caused by linting * Undo tslint formatting change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #5834 for #9496.
🛠 Created #9501 as a work item to re-introduce the behaviour that #5834 was originally fixing.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)