Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to "node2" debug engine #390

Merged
merged 14 commits into from
Feb 9, 2017
Merged

Migrate to "node2" debug engine #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e45838c
Reimplement debug adapter based on node2 adapter
Jan 31, 2017
f920e58
Fix number of issues appeared in prod
Jan 31, 2017
e38efae
Add more logging to diagnose debug issues in prod
Jan 31, 2017
a593f33
Launch debuggee in Node rather than in Electron
Feb 1, 2017
8049d42
Address FIXMEs
Feb 1, 2017
a8b90ac
Address TODOs:
Feb 1, 2017
4b86d59
Address review notes
Feb 2, 2017
e7b314e
Resolve issues with reloading app on Android
Feb 2, 2017
b05b508
Remove SingleLifetime worker, update tests
Feb 3, 2017
cc70057
Move worker downloading to MultipleLifetime worker
Feb 3, 2017
9174feb
Dispose worker properly when reloading
Feb 6, 2017
039239d
Update app worker tests
Feb 7, 2017
e90226e
Bump Node version on Travis
Feb 7, 2017
553b717
CR: Update unfinished comment
Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ os:
- osx

env:
- NODE_VERSION="5.11"
- NODE_VERSION="6.9.5"

before_install:
# nvm is not yet supported on osx, manually install
Expand Down
2 changes: 1 addition & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
},
{
"name": "Run mocha",
"type": "node",
"type": "node2",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"stopOnEntry": false,
// Command line arguments passed to the program.
Expand Down
4 changes: 1 addition & 3 deletions SampleApplication/.vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"type": "reactnative",
"request": "launch",
"platform": "android",
"internalDebuggerPort": 9090,
"sourceMaps": true,
"outDir": "${workspaceRoot}/.vscode/.react"
},
Expand All @@ -18,9 +17,8 @@
"request": "launch",
"platform": "ios",
"target": "iPhone 5s",
"internalDebuggerPort": 9090,
"sourceMaps": true,
"outDir": "${workspaceRoot}/.vscode/.react"
}
]
}
}
3 changes: 2 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ gulp.task('build', ["check-imports", "check-copyright"], function (callback) {
.pipe(sourcemaps.write('.', {
includeContent: false,
sourceRoot: function (file) {
return path.relative(path.dirname(file.path), __dirname + '/src');
return path.relative(path.dirname(path.dirname(file.path)), __dirname + '/src');
}
}))
.pipe(gulp.dest(outPath));
Expand Down Expand Up @@ -114,6 +114,7 @@ gulp.task('check-copyright', function (cb) {
"**/*.js",
"!**/*.d.ts",
"!node_modules/**",
"!out/test/**/*.js",
"!SampleApplication/**",
"!src/test/resources/sampleReactNative022Project/**/*.js",
])
Expand Down
Loading