Fix race conditions when reloading app on device #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid race conditions on app reload, when session dispatches another attach request to adapter (because app worker has sent connected' event) __before__ previous adapter instance was completely disposed we now create new instance of adapter closer to dispatching request, so session would always use new instance.
|
Also, shouldn't we add a notice about required Node version? I searched through docs but didn't find any info about Node.js version we require for debugging? |
|
Looks like it works great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues w/ starting/reloading app (introduced in #390) due to debug adapter conecting to stale app worker.
/cc @MSLaguana
Also as a side note - I'm still seeing Node's
GLOBALdeprecation message, but I doubt we could avoid it becauseGLOBAL's setter is also configured to emit this warning (see https://github.com/nodejs/node/blob/master/lib/internal/bootstrap_node.js#L203-L219)