-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with LCOW #29
Comments
Are we able to customize the run command? I want to replace how the extension is binding the .gitconfig. I rather just have it bind the entire directory to get around the limitation. |
@jsheetzati The |
Thanks @Chuxel. I was playing around with those options, but it seems like there is not a way to customize how .gitconfig gets binded. Due to LCOW not supporting binding a single file, I was hoping to override the .gitconfig binding and just bind my entire user directory.
|
@jsheetzati Ahhh go it - that's the key. Very good to know - thank you for clarifying. @chrmarti - FYI. I know we've talked about giving the option to alter the .gitconfig mount for other reasons (#509), but this is another hit on that particular issue. |
I would prefer not having a separate property in the devcontainer.json for this. We could allow an array for |
@chrmarti That works from my perspective. Would both a string or single entry then omit the .gitconfig mapping? Or just an array with one value? |
The presence of the property would omit the .gitconfig mapping unless it is explicitly included. Another option would be to copy the .gitconfig over if the exists on the host, but not in the container. (We currently have to inspect the image to get at the home folder in /etc/passwd before we launch the actual container with the .gitconfig mount which takes another slice of our startup time.) |
I believe this is now resolved since we're copying the .gitconfig file rather than mounting it, correct? |
Unfortunately, still seeing issues using LCOW.
|
We no longer mount any files into the container (unless configured in the devcontainer.json) and we no longer use |
@chrmarti I'm not sure, I haven't use LCOW in a long time. After WSL2 and it's Docker integration I don't need it anymore. If nobody can produce a repro, feel free to close the issue. |
@giggio Thanks, closing then. |
Steps to Reproduce:
docker pull --platform=linux node:12
.When you try to open the folder it fails. This is related to moby/moby#35425
You get an error
invalid mount config for type "bind": source path must be a directory.
because of the.gitconfig
file from HOME.Does this issue occur when you try this locally?: N/A
Does this issue occur when you try this locally and all extensions are disabled?: N/A
The text was updated successfully, but these errors were encountered: