Invalid mount path when connecting docker from windows to linux

[rebornix]

Re #474

• Followed Test: "docker.host" setting #474 (comment) to connect from Windows to a docker daemon on Ubuntu VM
• Open folder in container https://github.com/microsoft/vscode-dev-containers/tree/master/containers/typescript-node-lts
• See below error

C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from daemon: invalid mount config for type "bind": invalid mount path: 'c:/Users/penlv/code/vscode-dev-containers' mount path must be absolute.
See 'C:\Program Files\Docker\Docker\Resources\bin\docker.exe run --help'

[rebornix]

It's actually a duplicate of #489 but I still see this issue with 0.57.0

[chrmarti]

We automatically mount the project folder, but that is not possible when using a Docker daemon running on a different machine / VM. I'm not sure if there is an easy and reliable way to detect this case and not do the mount. (We could just not do it when "docker.host" is set.)

Workaround is to override the default mount with "workspaceMount" (can be empty or a valid value for docker run's --mount option.)

[egamma]

Closing: the user has to define workspaceMount in this setup.

[Chuxel]

Actually this is still an issue.

[Chuxel]

The specific issue here that is still outstanding is with the .gitconfig volume mount resulting in an invalid mount point. The mount does not fail anymore (see #489) which reduces the priority of the the main issue (except for on LCOW #29). However, Docker automatically creates a new path on the host to support the .gitconfig volume mount -- which pollutes the remote OS and could have other implications we haven't uncovered yet. For example, on my mac, .gitconfig is under /Users/chuck/.gitconfig for a user. Here's what I see on my remote Ubuntu SSH machine:

📁 Users
     📁 chuck
          📁 .gitconfig
📁 home
     📁 clantz
          📁 .ssh
          📁 .vscode-server
          📁 Repos
          📄 .gitconfig

The Users directory tree is created by Docker as a result of specifically the .gitconfig volume mount that you cannot override right now. The good news it doesn't bomb, but we need a way to disable this behavior to really fix this issue for good.

[wmeints]

This also fails when you're using Docker Desktop on Windows. I would expect for it to work normally there as this is a scenario that is widely used.

[Chuxel]

@wmeints If you running into trouble while using Docker locally, then that's a separate issue. Docker for Windows is known to work (I use it every day 😊). If you are using Windows containers (less common), then that's #29. But, if you're running Linux containers, it would be great if you'd raise an issue on it with your log details so we can try to help you sort it out.

[wmeints]

Thanks for the kind reply. I investigated it further and found some really weird behavior. I Will open a separate issue for that.

[chrmarti]

Verifier: The fix was to copy the .gitconfig into the container instead of trying to mount it. https://github.com/microsoft/vscode-remote-containers/commit/4f76bf525bc138e8fbc2bbfdc21f19c406e4cefa

Verify that the .gitconfig (if it exists in your local home folder) is indeed copied to the container (if it does not exist there yet) when the container is first created (but not later, e.g., after manually deleting it from the container).