Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote file picker input can backtrack while holding the delete key #4

Closed
mjbvz opened this issue Apr 26, 2019 · 3 comments · Fixed by microsoft/vscode#74675
Closed

Remote file picker input can backtrack while holding the delete key #4

mjbvz opened this issue Apr 26, 2019 · 3 comments · Fixed by microsoft/vscode#74675
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug remote Issues in the code server support verified Verification succeeded
Milestone
June 2019

Comments

@mjbvz
Copy link

mjbvz commented Apr 26, 2019

repo

  1. Open a remote folder (tested with containers and wsl)
  2. Open remote file open dialog
  3. Start at the end of the path and hold the delete key

Bug
While deleting, a segment of deleted path will sometimes be restored

Apr-26-2019 11-59-54
@egamma egamma transferred this issue from another repository May 2, 2019
@microsoft microsoft deleted a comment from mjbvz May 2, 2019
@egamma egamma added the bug Issue identified by VS Code Team member as probable bug label May 2, 2019
@alexr00 alexr00 added this to the May 2019 milestone May 2, 2019
@joeygibson joeygibson mentioned this issue May 3, 2019
Closed
@egamma egamma added the remote Issues in the code server support label May 6, 2019
alexr00 added a commit to microsoft/vscode that referenced this issue May 6, 2019
@alexr00
Fix file picker backtracking when holding delete key
2031ed1 
Fixes microsoft/vscode-remote-release#4
@alexr00 alexr00 mentioned this issue May 6, 2019
Closed
@Keno
Copy link

Keno commented May 7, 2019

I assume that's covered under this issue, but I see the same behavior with input other than backspace. If I add additional characters before the UI had a chance to offer completions, it'll mess up the input trying to provide the completion. On a moderate latency connection, this happens basically on every key stroke for me.

@rebornix rebornix added the verified Verification succeeded label May 30, 2019
@rebornix
Copy link
Member

remote-file-picker

If I deleted quickly, I can see flashing in the remote file picker. Reopen it but it's not a blocker of the release.

@rebornix rebornix added verification-found Issue verification failed and removed verified Verification succeeded labels May 30, 2019
@rebornix rebornix reopened this May 30, 2019
@alexr00 alexr00 mentioned this issue May 31, 2019
Merged
@alexr00 alexr00 modified the milestones: May 2019, June 2019 May 31, 2019
@alexr00
Copy link
Member

alexr00 commented May 31, 2019

This bug is slightly different from the original in that the added text is selected, so it deletes faster.

@alexr00 alexr00 removed the verification-found Issue verification failed label Jun 26, 2019
@jrieken jrieken added the verified Verification succeeded label Jun 27, 2019
@jrieken jrieken mentioned this issue Jun 27, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug remote Issues in the code server support verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

Successfully merging a pull request may close this issue.

Fix extra auto complete on fast delete microsoft/vscode
6 participants
@egamma @rebornix @Keno @jrieken @mjbvz @alexr00