Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote SSH forwards all ports #4185

Closed
rijenkii opened this issue Dec 14, 2020 · 6 comments
Closed

Remote SSH forwards all ports #4185

rijenkii opened this issue Dec 14, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote-explorer verified Verification succeeded
Milestone

Comments

@rijenkii
Copy link

rijenkii commented Dec 14, 2020

Issue Type: Bug

After a recent update VSCode started forwarding all ports that are opened on the remote machine by the user that is running the server -- before it just forwarded the ports that I have opened through the built-in terminal.
That in itself is not a much of a problem, until I try to connect to localhost -- then:

  • VSCode forwards all opened ports;
  • notices that some new ports have just opened (the ones that it just forwarded);
  • forwards them;
  • notices new opened ports;
  • forwards them

ad infinitum.

Extension version: 0.62.0
VS Code version: Code 1.52.0 (940b5f4bb5fa47866a54529ed759d95d09ee80be, 2020-12-10T22:45:11.850Z)
OS version: Windows_NT x64 6.3.9600
Remote OS version: Linux x64 5.9.13-arch1-1

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.94GB (7.24GB free)
Process Argv --crash-reporter-id b6c3bdcb-22b1-44b3-8ebf-87535db9be29
Screen Reader no
VM 0%
Item Value
Remote SSH: 90.189.172.126
OS Linux x64 5.9.13-arch1-1
CPUs Intel(R) Core(TM) i7-3632QM CPU @ 2.20GHz (8 x 1220)
Memory (System) 5.69GB (3.54GB free)
VM 0%
A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python763:30178808
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30211401
wsl2prompt:30224612
pythonvsdeb440:30233463
unusedprompt:30224610
folderexplorercf:30224615
openfilemenu:30224647
pythonvsded773cf:30233462
pythonvspyt600:30228411
vsjup459cf:30229594

@github-actions github-actions bot added the ssh Issue in vscode-remote SSH label Dec 14, 2020
@alexr00
Copy link
Member

alexr00 commented Dec 17, 2020

@rijenkii could you share a screenshot of the Ports view (by default it's in the Remote Explorer activity in the sidebar)? I want to make sure I understand what you're describing.

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Dec 17, 2020
@rijenkii
Copy link
Author

@alexr00 here
изображение

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug remote-explorer and removed info-needed Issue requires more information from poster ssh Issue in vscode-remote SSH labels Dec 21, 2020
@alexr00 alexr00 added this to the January 2021 milestone Dec 21, 2020
@alexr00
Copy link
Member

alexr00 commented Dec 22, 2020

@rijenkii I'm not able to reproduce this issue.

until I try to connect to localhost

What exactly are you doing to connect to localhost?

I tried to repro with the simple Microsoft/vscode-remote-try-node sample repo. My steps:

  1. Connect to an SSH remote
  2. Run node server.js, which runs a server listening on 3000
  3. See that 3000 is auto forwarded
  4. Open localhost:3000 in the browser

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Dec 22, 2020
@alexr00 alexr00 removed this from the January 2021 milestone Dec 22, 2020
@rijenkii
Copy link
Author

I have just reproduced this on a fresh install of Debian 10 with a fresh installed VSCode downloaded from code.visualstudio.com

Screenshots of steps

20201222-181907

20201222-181917

20201222-181926

20201222-181930

20201222-181938

Result

20201222-182207

@alexr00
Copy link
Member

alexr00 commented Dec 22, 2020

Thanks, that clarifies things. I can repro.

@alexr00 alexr00 added this to the January 2021 milestone Dec 22, 2020
@alexr00 alexr00 removed the info-needed Issue requires more information from poster label Dec 22, 2020
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 23, 2020
@alexr00
Copy link
Member

alexr00 commented Dec 24, 2020

Fixed by microsoft/vscode@0b1892f

@alexr00 alexr00 closed this as completed Dec 24, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug remote-explorer verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants