Extension icons sometimes not shown #687

eaglexiang · 2019-06-14T02:35:09Z

VSCode Version:1.35.1
Local OS Version: Linux Mint 19.1 Tessa
Remote OS Version: CentOS Linux release 7.6.1810 (Core)
Remote Extension/Connection Type: SSH

Steps to Reproduce:

open an remote folder
make some changes
plus/sub signal in git manager is not shown. where they mean staged changes or unstaged.

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No

joaomoreno · 2019-06-14T07:59:54Z

@eaglexiang Can you share a screenshot?

cc @jrieken @alexandrudima Icons from extensions seem to be missing.

eaglexiang · 2019-06-14T09:51:47Z

sorry it's not must reproduced. could you wait for its next appearance?

joaomoreno · 2019-06-14T09:54:25Z

I'll close this for now. Just comment once more if it appears. Or open a new issue.

eaglexiang · 2019-06-19T05:37:51Z

it happened again.

eaglexiang · 2019-06-19T05:39:01Z

as you see, + / - icon should be shown but not.

eaglexiang · 2019-06-24T10:01:36Z

@joaomoreno Could you reopen this issue?

joaomoreno · 2019-06-24T10:15:47Z

@jrieken Not sure if missing extension icons from a remote extension are your area.

jrieken · 2019-06-24T10:30:11Z

@jrieken Not sure if missing extension icons from a remote extension are your area.

👐 no clue... @eaglexiang Is this only about the +/- icons? Do other icons show? Is this something you only see when running remote?

eaglexiang · 2019-06-24T11:39:53Z

@jrieken yes it only happens with remote, and only misses + and –

jrieken · 2019-06-24T12:54:51Z

and only misses + and –

That's interesting... Just to double check you for instance always see the commit/refresh icons even then +/- are missing?

vscodebot · 2019-07-01T13:19:15Z

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

eaglexiang · 2019-07-02T06:47:39Z

Yes you're right, they all disapeared. It happened again and I found it this time.

@jrieken Please reopen this issue by the way.

walkafwalka · 2019-07-10T00:06:52Z

I am getting the same issue.

Error:

GET vscode-remote://wsl%2Bubuntu/home/awalker/.vscode-server-insiders/bin/4f3262dd1bba349e5be1e415a60874662da2c038/extensions/git/resources/icons/dark/clean.svg net::ERR_NOT_IMPLEMENTED

VSCode:

Version: 1.37.0-insider (user setup)
Commit: 4f3262dd1bba349e5be1e415a60874662da2c038
Date: 2019-07-08T23:49:44.487Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18932

WSL 2:

Distributor ID: Ubuntu
Description:    Ubuntu 18.04.2 LTS
Release:        18.04
Codename:       bionic

Posting my environment here. Hope it helps. Looks like this is a remote code issue.

tforster · 2019-07-12T15:15:10Z

TL;DR; Short term solution: Open project from File > Open or File > Open Recent and not from terminal with code .

After a lot of trial and error it appears that the issue has to do with how VSCode is launched. If I launch from my project folder, e.g. code . then my Docker, AWS and Remote SSH extension icons in the activity bar are blank (e.g. space is allocated but not icon appears). Also, if I rollover filenames in the repo explorer I don't see any of the Discard Changes, Stage Changes, etc icons. With Developer Tools open and clicking on the blank spaces I get the usual ERR_NOT_IMPLEMENTED error that @walkafwalka also noted.

Now, if I close the folder with File > Close Folder, goto File > Open Recent > {same project folder} the project reopens as expected but this time all my missing icons are present. I can also confirm that straight up File > Open and navigating to the project folder also works.

matt-FFFFFF · 2019-08-14T09:41:03Z

Also confirming this bug is still there on 1.37.0 on Windows. Close folder + Open Recent works, but is a little tiresome.

affan-ahmed · 2019-08-14T23:32:21Z

I hope this issue is fixed in a future release. I was thinking my extensions were not installing correctly!

offero · 2019-08-15T11:19:51Z

Same thing. Example here:

I run vscode-insiders . from inside of WSL 1.

ruslanguns · 2019-08-15T11:25:18Z

The bug only happen with Remote Connections WSL. Hopefully we get this fixed soon.
Opening the folder manually from local instead from the WSL connection will work fine for now. Just remember that it only happens if you do "code ." from WSL not this command from Powershell / GitBash or any other which runs local windows shell.

khpatel4991 · 2019-08-16T03:26:12Z

+1 ... on @ruslanguns approach but it would be nice to fix the core issue

tforster · 2019-08-16T16:15:05Z

FWIW I ave zero issue with the workaround and it's already become apart of my "muscle-memory". In fact, when it does get fixed, I am sure I will occasionally tap out the workaround out of habit.

VSCode is such an awesome tool and I have nothing but great things to say about it and all the people contributing to the codebase. Keep up the great work!

ruslanguns · 2019-08-18T18:10:23Z

Just tried with code-insiders . from wsl and still having issues.

alexdima · 2019-08-19T14:01:48Z

@ruslanguns Thank you for trying this out with insiders. This was very recently fixed. Did you try on this build? (check the date >= 19.08)

Also, since nobody from our team could reproduce this issue, I'd like to ask anyone that has suffered from this in the past to please try with the latest insiders and let me know if there are still issues.

Thank you!

devsetgo · 2019-08-19T18:57:38Z

I'll add my screenshot also. WSL remote.

Version: 1.37.1 (user setup)
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Date: 2019-08-15T16:17:55.855Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18956

affan-ahmed · 2019-08-19T19:04:35Z

@devsetgo It seems you aren't running the latest 1.38 insider version.

devsetgo · 2019-08-19T19:07:09Z

This is with Insider (just downloaded) and the icons are there. I have not install any plugins.

* Use bat on Windows * debt: use action bar from the panel view * Fix microsoft/vscode-remote-release/issues/1066 * fix label * fix: event's jsdoc typo * Move cleanRemoteAuthority function to common location * microsoft#78168 strict init * microsoft#78168 strict init * microsoft#78168 strict init * fixes microsoft#77797 * Split formatted text renderer into own file * Split MarkdownRenderOptions from FormattedTextRenderOptions * Rename htmlContentRenderer -> markdownRenderer * web - do not loose state on unload * open exter - move into opener service * add extension kind web * add action only in remote * Improve microsoft#79047 fix after feedback * use `vscode-remote`-endpoint when importing scripts * Added preserveCase in search side bar * test build schedule * Revert "test build schedule" This reverts commit 9d4ba37. * better check for worker/web extension * debt - IExtensionDescription#main should be relative like all other file references * move windowsIPC => common * very basic support to load multiple files * microsoft#69108 Move IWorkspaceStatsService to common Introduce a simple service for web * Fix microsoft#69108 * tests -remove unused services * Move getHashedRemotesFromUri to IWorkspaceStatsService * add and use `getWorkerBootstrapUrl`, don't use default worker factory anymore * - use strings for view zone ids - make it unlikely that a new view instance would accept a view zone id from a previous view instance - remove that the find widget removes a view zone id from another view (fixes microsoft#71745) * add `extensionHostWorker` entry point, fixes https://github.com/microsoft/vscode-internalbacklog/issues/738 * Update uglify-es (microsoft#79044) * Revert "Work around minifier bug (microsoft#79044)" This reverts commit 6371cad. * expose product configuration in product service * use product service * Simplify terminal commands * Improve typings, use async * uses getSelections and simplifed the return * Update distro * migrate keys from legacy layout microsoft#79020 * fix tests * Register driver * Teardown on sigint * Update markdown grammar * Still show fix all actions for fix-all actions that can fix multiple errors with multple different diagnostics * Base web user data dir off normal one * Update distro * Use new browser none arg * Make sure we compare fully normalized error codes when checking for fix all actions * Don't include closing ] in folded range Fixes microsoft#79142 * Register Remote Explorer when there are contributions. * Use undefined instead of null in IEditorOpeningEvent and IOpenEditorOverride * Change openEditor to return undefined instead of null For microsoft#70020 * Improve jsdoc section of walkthrough Fixes microsoft#71023 As discussed in microsoft#75033 * Add installer assets for OSS (microsoft#79045) * Revert "Update uglify-es (microsoft#79044)" This reverts commit e677c03. * Work around minifier bug (microsoft#79044) * debt - avoid some StrictNullOverride * debt - move issue service out of common since it will not be supported in the web for now * debt - make diagnostics service only accessible from node * update distro * tests - add more debug for randomly failing getUntitledWorkspacesSync * fix mispell * 💄 * update distro * Simplify tasks command * docs: fix type (microsoft#79129) * web - add todo for potentially cyclic dependency * Multi-select in custom tree view (microsoft#78625) Part of microsoft#76941 The first argument is now the element that the command is executed on. The second argurment is an array of the other selected items * update distro * web - enable feedback contribution * debt - more tests diag * do not look for executables in web * Move extension tips service to web and enable extension recommendations * use process.setImmediate * minor polish * fixes microsoft#79168 * fix exports trap * debug: prevent expression.value being undefined fixes microsoft#79169 * update distro * web - implement credentials provider and add API * web - workaround clipboard issue with selection type * better exports trapping * fix process layer-breaker * debt - avoid process dependency in common * rawDebugSession: do not use process microsoft#79210 * remove proposed API `vscode.commands.onDidExecuteCommand` * Fix microsoft#79206 * callStack view: do not show thread when there is only one to be compact fixes microsoft#79121 * fix compile error * inline product configuration in produt service * update distro * Fix strict error * fix tests * Do not expand session tree node when selecting it fixes microsoft#79184 * Fix issue with CustomExecutions not working through tasks.executeTask (microsoft#79132) * Do not clear out the map, and track the provided execution during execute task * Clear provided custom executions map on execution complete * Save last custom execution * use safeprocess env * Remove click code from puppeteer driver, move interfaces to common * Reduce diff * fix typos * web - reuse require interceptor logic * remove FakeCommonJSSelf * Fix dispatch keybinding when called multiple times * Fix layer breakage Part of microsoft#79210 * Fixes microsoft#78975: Look for autoclosing pairs in edits coming in from suggestions * Remove smoke tests from CI for now * Reduce diff * Add setting to toggle new octicon style * Update distro * Move puppeteer to dev deps * Run smoke tests for darwin/linux in CI * Make display name consistent * Fix indent * Improve token regex * Add connectionToken * update distro * Update search stop icon * Update checkmark so they look more like a ✓ * introduce RemoteAuthorities * remote explorer and contribution under proposed api * Disable smoke tests on Linux Puppeteer needs special user setup in order to launch * Strict init microsoft#78168 * Strict init and mark events readonly microsoft#78168 * Remove extra null checks in coalesce The type system should catch these now * Add telemetry+warning for webviews that don't have a content security policy Fixes microsoft#79248 * Fixing comment * Update distro * Update distro * Don't dispose of added object in already disposed of case Fixes microsoft#77192 See microsoft#77192 for discussion * Mark readonly * Use const enums * Marking fields readonly * Remove webview svg whitelist This is no longer required * Removing test for disposable store We have disabled this behavior * build - disable smoketest * Enable new Octicons style by default * fix web platform check * better worker error logging * make sure to prepend vs/nls * 💄 * fix: keep the two "Copy Path" behavior consistent When using remote, this "Copy Path" function of SearchAction will keep the remote prefix while the FileCommand will not. Change-Id: Ide00d2da5a695d0adbe87622643c7a600dd46432 * Load Octicons through ts instead of css import * update distro * Fixes microsoft#79166 * web - synchronise global state changes * explorer input black magic fixes microsoft#78153 * fix microsoft#72417 * Fix smoke tests * Revert "build - disable smoketest" This reverts commit c23cacd. * Scope new variable to a string * Fallback to default when cwd var cannot be resolved Fixes microsoft#79281 * fix error when dismissing snippets picker * add fetch file system provider * add IStaticExtensionsService, add `staticExtensions` to embedder API * make staticExtensions optional * Indicate web in smoke test step * Update octicon css logic * Fix Octicon icons on Linux * debug: introduce data breakpoints * Introduce and adopt asCSSUrl * Fixes microsoft/vscode-remote-release#687: - remove ipc message that passes over the resolved authority - don't go through the protocol handler when hitting 127.0.0.1 * Introduce machine overridable setting * Seti uses TS-icon for jsonc-language. Fixes microsoft#78261 * Pick up TS rc * [email protected] - Better align search with how monaco does it Fixes microsoft#78281 * Format file * Update distro * Remove not null suppression * Use dispoablestore * Use closure instead of parameters * Use type for IExtensionPointHandler and mark array readonly * Marking arrays readonly in ExtensionPointUserDelta * web - storage/lifecycle 💄 * Fix microsoft#79326, cleanup rendering Octicons bugs on Windows/Linux * fix Markdown Preview scroll remains same after clicking on some other link * Fix trivial zsh completion typo * Improvements * Drop Configure Trusted Domains command for now * 💄 * Drop details & on -> from * Address feedbacks * Fix services * Storage instead of setting. Add command for configuring * Don't add star to quickpick * Update UX * Build errors and test failures * 💄 * debt - fix some layer breakers * Added buildReplaceStringWithCasePreserved generic function to be used in both search side and the find side * 💄 imports * refactor: GlobalStorageDatabaseChannel should dependents in IStorageMainService (microsoft#79387) * 💄 * build - have different worker extension host entrypoint, copy worker bootstrap file * fix microsoft#76573 * fix path * update distro * Localization test fails on remote smoketest. Fixes microsoft#78412 * Fix microsoft/vscode-remote-release/issues/1027 * fix scope when falling back to original load function * Wording update * Fix: Markdown Preview scroll remains same after clicking on some other link microsoft#78465 Improves the behavior on how markdown preview behaves when clicking a link * microsoft#79429 * TSLint: show a warning when accessing node.js globals in common|browser (microsoft#79222) * trivial first cut * document where globals are from * improve rule detection * fix "gulp tslint" task * share rules * enable more rules * also add a rule for DOM * Update trustedDomain default config * tslint - disable some rules with comments (microsoft#79454) * Drop unneeded action registration * update distro * Support using csharp in markdown preview to identify c# code blocks * sync diagnostics, fixes microsoft#47292 * fixes microsoft#79280 * tests - more diagnostics for getUntitledWorkspaceSync() random failures * debt - reduce dependencies diff to E6 branch * update distro * debt - menubar service should not live in common (microsoft#79181) * distro * Unify trusted domain language and use quick pick item id * Update browser telemetry common properties * microsoft#79454 Fix warnings * Fix microsoft#79429 * Fix hygiene check

riserrad · 2019-08-26T22:35:50Z

I'm still facing this issue. And @odaibert is facing this issue on a default VSCode session (non-VSCode Remote/WSL)

Should we do anything on our VSCode installations to get this issue fixed? No updates available.

alexdima · 2019-08-27T14:56:36Z

@ricardoserradas Are you using insiders? The stable release will most likely roll out next week

If @odaibert sees missing icons in a non-remote VS Code window, then please create an issue directly against VS Code at https://github.com/microsoft/vscode and please detail exactly what VS Code version you are using, what OS, what extensions, and with a screenshot, what icons are missing.

r2luna · 2019-08-28T19:51:18Z

Any updates? Also having the same issues.

alexdima · 2019-08-29T13:12:20Z

@r2luna The issue is fixed. The fix is available on VS Code Insiders. The fix will be available on VS Code Stable with the August 1.38 release.

ShiftyMcCool · 2019-09-06T13:46:12Z

I have upgraded to stable 1.38 and this issue just started for me (did not seem present in 1.37). The trick outlined by @tforster did not work for me, the icons are always missing, although I did see them reappear at random once (unable to reproduce so far).

Windows 10 1809 / WSL
VS Code 1.38

EDIT: for some reason it decided to work, no changes on my side to make it work.
EDIT 2: broke again as soon as I made the previous edit... used the Project Manager plugin to change projects and now the icons won't come back

alexdima · 2019-09-11T15:25:16Z

@ShiftyMcCool Can you please open a new issue with the issue reporter so we can get more information about your environment? We have also changed the implementation to such an extent that it really deserves a new issue...

ruslanguns · 2019-09-11T20:43:16Z

In my side is fixed. El mié., 11 de sep. de 2019 a la(s) 17:25, Alexandru Dima ( [email protected]) escribió:

…

@ShiftyMcCool <https://github.com/ShiftyMcCool> Can you please open a new issue with the issue reporter so we can get more information about your environment? We have also changed the implementation to such an extent that it really deserves a new issue... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#687?email_source=notifications&email_token=AEXDV6FTMCZXOQCUKDW2W3TQJEEX7A5CNFSM4HYDJJRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6O4CKQ#issuecomment-530432298>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEXDV6ANPCRKV4NIYVBNP6TQJEEX7ANCNFSM4HYDJJRA> .

ShiftyMcCool · 2019-09-12T13:03:04Z

@ShiftyMcCool Can you please open a new issue with the issue reporter so we can get more information about your environment? We have also changed the implementation to such an extent that it really deserves a new issue...

Hi @alexandrudima,

Just opened #1407 for this issue. Thanks!

egamma assigned joaomoreno Jun 14, 2019

joaomoreno removed their assignment Jun 14, 2019

joaomoreno self-assigned this Jun 14, 2019

joaomoreno added the info-needed Issue requires more information from poster label Jun 14, 2019

joaomoreno closed this as completed Jun 14, 2019

joaomoreno reopened this Jun 24, 2019

joaomoreno removed the info-needed Issue requires more information from poster label Jun 24, 2019

joaomoreno assigned jrieken and alexdima and unassigned joaomoreno Jun 24, 2019

jrieken changed the title ~~plus/sub signal is not shown~~ plus/sub icon is not shown Jun 24, 2019

jrieken added the info-needed Issue requires more information from poster label Jun 24, 2019

vscodebot bot closed this as completed Jul 1, 2019

jrieken reopened this Jul 2, 2019

patesson mentioned this issue Jul 9, 2019

The missing extension icons in side bar #924

Closed

miguelsolorio mentioned this issue Jul 9, 2019

Various svg icons missing microsoft/vscode#77007

Closed

kieferrm mentioned this issue Aug 12, 2019

Iteration Plan for August 2019 microsoft/vscode#78844

Closed

37 tasks

egamma mentioned this issue Aug 13, 2019

Custom icons not appearing with wsl remote turned on #1138

Closed

IllusionMH mentioned this issue Aug 16, 2019

WSL control git can't show button add remove microsoft/vscode#79298

Closed

alexdima unassigned jrieken Aug 16, 2019

alexdima closed this as completed in microsoft/vscode@265dba5 Aug 16, 2019

gjsjohnmurray mentioned this issue Aug 17, 2019

Icons missing in remote wsl in windows microsoft/vscode#79353

Closed

egamma mentioned this issue Aug 20, 2019

Invisible git buttons #1189

Closed

aeschli added the verified Verification succeeded label Aug 30, 2019

IllusionMH mentioned this issue Sep 4, 2019

Icons missing from sidebar in WSL - #687 on github microsoft/vscode#80305

Closed

vscodebot bot locked and limited conversation to collaborators Sep 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extension icons sometimes not shown #687

Extension icons sometimes not shown #687

eaglexiang commented Jun 14, 2019

joaomoreno commented Jun 14, 2019 •

edited

Loading

eaglexiang commented Jun 14, 2019

joaomoreno commented Jun 14, 2019

eaglexiang commented Jun 19, 2019

eaglexiang commented Jun 19, 2019

eaglexiang commented Jun 24, 2019

joaomoreno commented Jun 24, 2019 •

edited

Loading

jrieken commented Jun 24, 2019

eaglexiang commented Jun 24, 2019

jrieken commented Jun 24, 2019

vscodebot bot commented Jul 1, 2019

eaglexiang commented Jul 2, 2019

walkafwalka commented Jul 10, 2019

tforster commented Jul 12, 2019

matt-FFFFFF commented Aug 14, 2019

affan-ahmed commented Aug 14, 2019

offero commented Aug 15, 2019

ruslanguns commented Aug 15, 2019

khpatel4991 commented Aug 16, 2019

tforster commented Aug 16, 2019

ruslanguns commented Aug 18, 2019

alexdima commented Aug 19, 2019

devsetgo commented Aug 19, 2019

affan-ahmed commented Aug 19, 2019

devsetgo commented Aug 19, 2019

riserrad commented Aug 26, 2019

alexdima commented Aug 27, 2019

r2luna commented Aug 28, 2019

alexdima commented Aug 29, 2019

ShiftyMcCool commented Sep 6, 2019 •

edited

Loading

alexdima commented Sep 11, 2019

ruslanguns commented Sep 11, 2019 via email

ShiftyMcCool commented Sep 12, 2019

Extension icons sometimes not shown #687

Extension icons sometimes not shown #687

Comments

eaglexiang commented Jun 14, 2019

joaomoreno commented Jun 14, 2019 • edited Loading

eaglexiang commented Jun 14, 2019

joaomoreno commented Jun 14, 2019

eaglexiang commented Jun 19, 2019

eaglexiang commented Jun 19, 2019

eaglexiang commented Jun 24, 2019

joaomoreno commented Jun 24, 2019 • edited Loading

jrieken commented Jun 24, 2019

eaglexiang commented Jun 24, 2019

jrieken commented Jun 24, 2019

vscodebot bot commented Jul 1, 2019

eaglexiang commented Jul 2, 2019

walkafwalka commented Jul 10, 2019

tforster commented Jul 12, 2019

matt-FFFFFF commented Aug 14, 2019

affan-ahmed commented Aug 14, 2019

offero commented Aug 15, 2019

ruslanguns commented Aug 15, 2019

khpatel4991 commented Aug 16, 2019

tforster commented Aug 16, 2019

ruslanguns commented Aug 18, 2019

alexdima commented Aug 19, 2019

devsetgo commented Aug 19, 2019

affan-ahmed commented Aug 19, 2019

devsetgo commented Aug 19, 2019

riserrad commented Aug 26, 2019

alexdima commented Aug 27, 2019

r2luna commented Aug 28, 2019

alexdima commented Aug 29, 2019

ShiftyMcCool commented Sep 6, 2019 • edited Loading

alexdima commented Sep 11, 2019

ruslanguns commented Sep 11, 2019 via email

ShiftyMcCool commented Sep 12, 2019

joaomoreno commented Jun 14, 2019 •

edited

Loading

joaomoreno commented Jun 24, 2019 •

edited

Loading

ShiftyMcCool commented Sep 6, 2019 •

edited

Loading