Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrated.inheritEnv not working on remote #823

Closed
kieferrm opened this issue Jun 26, 2019 · 2 comments
Closed

terminal.integrated.inheritEnv not working on remote #823

kieferrm opened this issue Jun 26, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

While testing microsoft/vscode#76053.

  1. open remote ssh workspace
  2. set terminal.integrated.inheritEnv to true
  3. destroy all existing terminals and create a new one
  4. env > inherit.txt
  5. set terminal.integrated.inheritEnv to false
  6. destroy all existing terminals and create a new one
  7. env > clean.txt
  8. compare clean.txt and inherit.txt
    -> no differences
    In my case SHLVL=4 in both and shouldn't.
@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2019

The setting doesn't actually do anything on remote just yet as I didn't think through it fully. I'll have a look to see if doing the same thing will work across each of the extensions.

@Tyriar Tyriar added this to the June 2019 milestone Jun 26, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2019

Ok, this should work on remote now, SHLVL=3 for me which I think is fine since ssh is a shell. The main thing to look out for in remote is that your bashrc only runs once (and doesn't duplicate in the PATH environment).

@Tyriar Tyriar closed this as completed Jun 26, 2019
@chrmarti chrmarti added the verified Verification succeeded label Jun 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants