Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test terminal.integrated.inheritEnv #76053

Closed
3 tasks done
Tyriar opened this issue Jun 25, 2019 · 3 comments
Closed
3 tasks done

Test terminal.integrated.inheritEnv #76053

Tyriar opened this issue Jun 25, 2019 · 3 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2019

Test for #70248

Complexity: 3

There is a new setting terminal.integrated.inheritEnv which when set to false will not use inherit window's environment, instead:

  • On Linux it will get the parent of the main process and fetch its environment via procfs
  • On macOS it will create a new environment taking only a few keys from the current environment
  • On Windows nothing (deferred in another issue)

This was added such that the integrated terminal would work more like a regular terminal and not jumble $PATH up by running the profile/rc scripts several times. Things to verify:

Some more context: #70248, #75376,

@Tyriar Tyriar added this to the June 2019 milestone Jun 25, 2019
@rebornix
Copy link
Member

@Tyriar if I understand correctly, I should not expect the same result for echo $PATH when using SSH extension, right?

@kieferrm
Copy link
Member

This works as expected locally on macOS. Issues on Linux remote. See microsoft/vscode-remote-release#823.

@kieferrm kieferrm removed their assignment Jun 26, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jun 26, 2019

@rebornix see microsoft/vscode-remote-release#823 for remote

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants