Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tree, after packing the extension, does not take the out option into account #1074

Closed
vanyauhalin opened this issue Nov 2, 2024 · 4 comments · Fixed by #1101
Closed
Assignees
Labels
author-verification-requested feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@vanyauhalin
Copy link

vsce package --allow-unused-files-pattern --no-dependencies --out moondusttheme.vsix
 INFO  Files included in the VSIX:
moondusttheme-0.7.0.vsix                      <- here
├─ [Content_Types].xml 
├─ extension.vsixmanifest 
└─ extension/
   ├─ LICENSE.txt [1.07 KB]
   ├─ package.json [1.66 KB]
   ├─ readme.md [0.12 KB]
   ├─ dist/
   │  ├─ dark.json [135.73 KB]
   │  └─ light.json [135.93 KB]
   └─ docs/
      └─ icon.png [15.8 KB]

 DONE  Packaged: moondusttheme.vsix (8 files, 42.98 KB)
@benibenj benibenj added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Nov 25, 2024
@benibenj benibenj added this to the January 2025 milestone Dec 10, 2024
@vanyauhalin
Copy link
Author

Thanks!

luxass pushed a commit to luxass/vscode-vsce that referenced this issue Dec 15, 2024
@benibenj benibenj added verification-needed Verification of issue is requested author-verification-requested labels Jan 28, 2025
@alexr00
Copy link
Member

alexr00 commented Jan 29, 2025

@benibenj I don't see a new version that has this change. What's the best way to verify?

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Jan 29, 2025
@benibenj
Copy link
Contributor

benibenj commented Jan 29, 2025

Will be in the patch release 3.2.2 today.

For each change in VSCE we create a pre-releases which you can get with @next version. So it can also be tested with the version 3.2.2-5
https://www.npmjs.com/package/@vscode/vsce?activeTab=versions

This can be tested by packaging an extension with the --out flag and checking that the tree which is printed uses the name of the --out parameter

@benibenj benibenj removed verification-steps-needed Steps to verify are needed for verification help wanted Issues identified as good community contribution opportunities labels Jan 29, 2025
@TylerLeonhardt
Copy link
Member

Looks good:

npx @vscode/vsce@next package --out foo.vsix
Executing prepublish script 'npm run vscode:prepublish'...

> [email protected] vscode:prepublish
> npm run package


> [email protected] package
> webpack --mode production --devtool hidden-source-map

    [webpack-cli] Compiler starting... 
    [webpack-cli] Compiler is using config: '/Users/tyleonha/Code/Microsoft/vscode-websearchparticipant/webpack.config.js'
    [webpack-cli] Compiler finished
asset extension.js 2.81 MiB [emitted] [minimized] (name: main) 2 related assets
831 modules
webpack 5.95.0 compiled successfully in 7386 ms
 INFO  Files included in the VSIX:
foo.vsix
├─ [Content_Types].xml 
├─ extension.vsixmanifest 
└─ extension/
   ├─ LICENSE.txt [1.11 KB]
   ├─ SECURITY.md [2.59 KB]
   ├─ cached-embeddings.json [2.54 MB]
   ├─ icon.png [18.84 KB]
   ├─ package.json [4.08 KB]
   ├─ package.nls.json [1.34 KB]
   ├─ readme.md [2.39 KB]
   ├─ dist/
   │  ├─ extension.js [2.81 MB]
   │  └─ extension.js.LICENSE.txt [2.55 KB]
   └─ model/
      └─ cl100k_base.tiktoken [1.6 MB]

 DONE  Packaged: foo.vsix (12 files, 2.37 MB)
 WARNING  The latest version of @vscode/vsce is 3.2.2 and you have 3.2.2-5.

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants