Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted svg badge provider #240

Closed
equinusocio opened this issue Feb 19, 2018 · 4 comments
Closed

Trusted svg badge provider #240

equinusocio opened this issue Feb 19, 2018 · 4 comments
Assignees

Comments

@equinusocio
Copy link

equinusocio commented Feb 19, 2018

Hi, i noticed that opencollective.com is now a trusted badge provider but i get this error when i publish my extension:

Error processing 'Equinusocio.vsc-material-theme' SVG reference in file '/extension/README.md'. Your reference to the SVG image ‘https://opencollective.com/vsc-material-theme/contributors.svg?width=890’ is not supported. Please see https://aka.ms/vsmarketplace_badge for more details.

Also opencollective.com doesn't appear here:
https://docs.microsoft.com/it-it/vsts/extend/develop/manifest#supported-badge-services

Using the vsce release.

@joaomoreno joaomoreno self-assigned this Feb 20, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Feb 20, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Feb 20, 2018

Apparently, the Marketplace is also doing checks on the badges.

@viradhamMS @pkuma-msft Can we whitelist the following domains?

  • deepscan.io
  • githost.io
  • gitlab.com
  • opencollective.com

cc @mjbvz As far as I understood, these were the ones recently added.

@pkuma-msft
Copy link

@equinusocio Sorry for the inconvenience, I'll add these domains to our whitelist and update this thread.

@pkuma-msft
Copy link

We have made the change at our end, the publish should go through now. Please try and let us know if you still see any issues.

@joaomoreno
Copy link
Member

Thanks @pkuma-msft! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants