-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add readme path override #722
Conversation
Why exactly does the need for SVG warrant supporting different locations for README.md? This is definitely out of scope, since changes would need to happen across the board: the Markteplace itself as well as VS Code, not just vsce. |
because I have in the readme file a github action badges, so i want to create the same readme without them and send him his path to packing/deploying process in vsce because vsce deploying failed on include svg in readme |
so in this way you can manage a readme file for vscode and readme file for git |
i find that there was an issue that talk about it too that you add some domain to whitelist, in my git i use github relative links of badges to make it work also it the forks of the main repo |
What domain do your svg icons come from? Any chance you can use PNG or some other image format? |
no like i said its a github actions bagdes, they give you an svg not an png
|
It is incredibly error prone to use
Because maybe it makes vsce happy, but VS Code won't know that your extension's README.md will be somewhere else. Also, the VS Marketplace won't be aware as well. |
need the support of use different readme file when you pack\publish an extension
i saw that there was an issue that close because it was out of scope, and i need it because my readme contains svgs, and it was very easy to add this support
#210