Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate sponsor URL #735

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix: validate sponsor URL #735

merged 2 commits into from
Jun 1, 2022

Conversation

sandy081
Copy link
Member

Fixes #734

@sandy081 sandy081 requested a review from joaomoreno May 31, 2022 16:29
@sandy081 sandy081 self-assigned this May 31, 2022
@sandy081
Copy link
Member Author

CC @isidorn

Instead of naming just sponsor, how about calling this property sponsorUrl so that it is more obvious?

@isidorn
Copy link
Contributor

isidorn commented May 31, 2022

@sandy081 sponsorUrl works for me.

Naming wise it sort of aligns with the repository field that has a url field in it.
Screenshot 2022-05-31 at 19 03 50

@sandy081
Copy link
Member Author

I like sponsor object with url property. It can be extended if needed in future.

@isidorn
Copy link
Contributor

isidorn commented May 31, 2022

Cool. Works for me :)

@sandy081 sandy081 merged commit 95823b6 into main Jun 1, 2022
@sandy081 sandy081 deleted the sandy081/horrible-rat branch June 1, 2022 08:05
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@sandy081 sandy081

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor url validation for sponsor field would be useful
3 participants
@sandy081 @isidorn @joaomoreno