Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Data grid: long headers not aligned with cells #411

Closed
fengtan opened this issue Oct 31, 2022 · 1 comment · Fixed by #412
Closed

Data grid: long headers not aligned with cells #411

fengtan opened this issue Oct 31, 2022 · 1 comment · Fixed by #412
Assignees
Labels
bug Something isn't working

Comments

@fengtan
Copy link
Contributor

fengtan commented Oct 31, 2022

Describe the bug

If a data grid has long headers, then those aren't always aligned with cells.

To reproduce

Create a data grid by following the official documentation and specify many long headers with no space.

For instance:

  const row1 = {};
  const row2 = {};
  for(i=1;i<20;i++) {
    row1["aVeryLongHeader"+i] = "value"+i;
    row2["aVeryLongHeader"+i] = "aVeryLongValue"+i;
  };
  document.getElementById("grid").rowsData = [row1, row2];

Expected behavior

Headers and cells should be aligned so you can clearly identify the columns:

proposed

Current behavior

Headers are not aligned with the cells. Note that all cells are aligned so the problem is specific to headers vs regular cells:

current

Desktop (please complete the following information):

  • OS Version: Ubuntu 20.04.5 LTS
  • Toolkit Version: v1.0.1
@hawkticehurst
Copy link
Member

Thank you for this catch and subsequent PR! Tested it all on my end and was able to validate both the issue and the fix :)

fengtan added a commit to fengtan/ldap-explorer that referenced this issue Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants