-
Notifications
You must be signed in to change notification settings - Fork 147
add storybook link and adjust CONTRIBUTING.MD #492
add storybook link and adjust CONTRIBUTING.MD #492
Conversation
0e91727
to
ac0f754
Compare
@microsoft-github-policy-service agree company="Nx" |
Hey @MaxKless, thanks for the PR! Removing links to Storybook was actually an intentional change because our Storybook build pipeline broke with no easy fix awhile ago. As a result, we switched all our documentation samples to use CodeSandbox and those now operate as the official and most up-to-date version of interactive code snippets/samples. I left the Storybook published for posterity purposes. But without an ability to denote that the docs are deprecated (since we can't build/publish new versions) I realize we should probably just remove it –– especially if people are still able to find the docs like you did. Hope that all makes sense and let me know if you have any questions! :) |
With all that said, thank you for the catch on the contributing docs mismatch! If you want to adjust this PR so the only change is removing the |
ac0f754
to
509d53c
Compare
Ah that's good to know! I guess I will stop using it then :P Updated the PR. |
Of course, happy to do so! And thank you for updating, I'll give a quick review now |
509d53c
to
4ac8b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you so much! :)
The storybook is a great resource for the toolkit but it's not linked anywhere in the repo.
Also, some of the scripts listed in CONTRIBUTING.MD don't exist anymore.