Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

data-grid: changes display from 'flex' to 'grid', and removes flex-direction #517

Closed
wants to merge 1 commit into from

Conversation

joacoc
Copy link

@joacoc joacoc commented Nov 5, 2023

Link to relevant issue

This pull request resolves #473

Description of changes

This PR modifies the style of vscode-data-grid by changing the display property from flex to grid and removing the flex-direction property.

Component gallery test screenshot Screenshot

@hawkticehurst
Copy link
Member

Thanks for the PR @joacoc! 😊

As I just discussed in the related issue thread I'm actually unsure if this fixes the problems that are described in #473 (or at least I was unable to produce a solution with the changes you provided).

Could you describe a bit more of what issue(s) you were facing and how the changes in this PR fixed your issue?

@hawkticehurst
Copy link
Member

Going to go ahead and close this PR since the toolkit is going to be deprecated by the end of the year (more info at #561). Thanks again for trying to help out on this one :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode-data-grid with grid-template-columns is not respected
2 participants