fix compile errors

microsoft · Jan 13, 2020 · 5e758c1 · 5e758c1
1 parent 561f521
commit 5e758c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/src/vs/workbench/contrib/search/browser/openSymbolHandler.ts b/src/vs/workbench/contrib/search/browser/openSymbolHandler.ts
@@ -119,14 +119,11 @@ class SymbolEntry extends EditorQuickOpenEntry {
 		const input: IResourceInput = {
 			resource: this.bearing.location.uri,
 			options: {
-				pinned: !this.configurationService.getValue<IWorkbenchEditorConfiguration>().workbench.editor.enablePreviewFromQuickOpen
+				pinned: !this.configurationService.getValue<IWorkbenchEditorConfiguration>().workbench.editor.enablePreviewFromQuickOpen,
+				selection: this.bearing.location.range ? Range.collapseToStart(this.bearing.location.range) : undefined
 			}
 		};
 
-		if (this.bearing.location.range) {
-			input.options!.selection = Range.collapseToStart(this.bearing.location.range);
-		}
-
 		return input;
 	}
 

diff --git a/src/vs/workbench/services/history/browser/history.ts b/src/vs/workbench/services/history/browser/history.ts
@@ -354,15 +354,11 @@ export class HistoryService extends Disposable implements IHistoryService {
 
 	private doNavigate(location: IStackEntry): Promise<IBaseEditor | undefined> {
 		const options: ITextEditorOptions = {
-			revealIfOpened: true // support to navigate across editor groups
+			revealIfOpened: true, // support to navigate across editor groups,
+			selection: location.selection,
+			revealInCenterIfOutsideViewport: !!location.selection
 		};
 
-		// Support selection and minimize scrolling by setting revealInCenterIfOutsideViewport
-		if (location.selection) {
-			options.selection = location.selection;
-			options.revealInCenterIfOutsideViewport = true;
-		}
-
 		if (location.input instanceof EditorInput) {
 			return this.editorService.openEditor(location.input, options);
 		}