Issue reporter: changes to "reproducible section", fixes #42365

microsoft · Jan 29, 2018 · 8b260fb · 8b260fb
1 parent e91b851
commit 8b260fb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/src/vs/code/electron-browser/issue/issueReporterMain.ts b/src/vs/code/electron-browser/issue/issueReporterMain.ts
@@ -69,7 +69,7 @@ export class IssueReporter extends Disposable {
 				os: `${os.type()} ${os.arch()} ${os.release()}`
 			},
 			extensionsDisabled: this.environmentService.disableExtensions,
-			reprosWithoutExtensions: true
+			reprosWithoutExtensions: false
 		});
 
 		ipcRenderer.on('issueInfoResponse', (event, info) => {

diff --git a/src/vs/code/electron-browser/issue/issueReporterPage.ts b/src/vs/code/electron-browser/issue/issueReporterPage.ts
@@ -94,9 +94,9 @@ export default (): string => `
 			</details>
 			<div>
 				<label for="reprosWithoutExtensions">${escape(localize('tryDisablingExtensions', "Is the problem reproducible when extensions are disabled?"))}</label>
-				<input type="checkbox" id="reprosWithoutExtensions" checked>
-				<button id="disableExtensions" class="workbenchCommand">${escape(localize('disableExtensions', "Disable Extensions and Reload"))}</button>
-				<button id="showRunning" class="workbenchCommand">${escape(localize('showRunningExtensions', "Show Running Extensions"))}</button>
+				<input type="checkbox" id="reprosWithoutExtensions">
+				<div class="instructions">Try to reproduce the problem after <button id="disableExtensions" class="workbenchCommand">${escape(localize('disableExtensions', "disabling all extensions and reloading the window"))}</button>.</div>
+				<div class="instructions">If you suspect it's an extension issue, <button id="showRunning" class="workbenchCommand">${escape(localize('showRunningExtensions', "see all running extensions"))}</button>.</div>
 			</div>
 		</div>
 	</div>
@@ -105,11 +105,11 @@ export default (): string => `
 		<label for="description" id="issue-description-label">
 			<!-- To be dynamically filled -->
 		</label>
-		<small id="issue-description-subtitle">
+		<div class="instructions" id="issue-description-subtitle">
 			<!-- To be dynamically filled -->
-		</small>
+		</div>
 		<div class="block-info-text">
-			<small>${escape(localize('githubMarkdown', "We support GitHub-flavored Markdown. You will be able to edit your issue and add screenshots when we preview it on GitHub."))}</small>
+			<div class="instructions">${escape(localize('githubMarkdown', "We support GitHub-flavored Markdown. You will be able to edit your issue and add screenshots when we preview it on GitHub."))}</div>
 			<div id="description-validation-error" class="validation-error hidden">${escape(localize('issueDescriptionRequired', "Please enter a description."))}</div>
 			<textarea name="description" id="description" cols="100" rows="15" required></textarea>
 		</div>

diff --git a/src/vs/code/electron-browser/issue/media/issueReporter.css b/src/vs/code/electron-browser/issue/media/issueReporter.css
@@ -49,13 +49,6 @@ textarea {
 	overflow: auto;
 	resize: vertical;
 }
-small {
-	color: #868e96;
-	display: block;
-	margin-top: .25rem;
-	font-size: 80%;
-	font-weight: 400;
-}
 
 /**
  * Button
@@ -197,8 +190,14 @@ input:disabled {
 	margin-left: 1em;
 }
 
+.instructions {
+	font-size: 12px;
+	margin-left: 1em;
+	margin-top: .5em;
+}
+
 .workbenchCommand {
-	display: block;
+	padding: 0;
 	font-size: 12px;
 	background: transparent;
 }