Merge pull request #189685 from microsoft/tyriar/type_remote

Use const enum values instead of strings for remote calls
microsoft · Aug 4, 2023 · 90fb257 · 90fb257
2 parents 24cfdda + 8959846
commit 90fb257
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/vs/workbench/contrib/terminal/common/remote/remoteTerminalChannel.ts b/src/vs/workbench/contrib/terminal/common/remote/remoteTerminalChannel.ts
@@ -185,7 +185,7 @@ export class RemoteTerminalChannelClient implements IPtyHostController {
 			unicodeVersion,
 			resolverEnv
 		};
-		return await this._channel.call<ICreateTerminalProcessResult>('$createProcess', args);
+		return await this._channel.call<ICreateTerminalProcessResult>(RemoteTerminalChannelRequest.CreateProcess, args);
 	}
 
 	requestDetachInstance(workspaceId: string, instanceId: number): Promise<IProcessDetails | undefined> {
@@ -281,7 +281,7 @@ export class RemoteTerminalChannelClient implements IPtyHostController {
 			workspaceId: workspace.id,
 			tabs: layout ? layout.tabs : []
 		};
-		return this._channel.call<void>('$setTerminalLayoutInfo', args);
+		return this._channel.call<void>(RemoteTerminalChannelRequest.SetTerminalLayoutInfo, args);
 	}
 
 	updateTitle(id: number, title: string, titleSource: TitleEventSource): Promise<string> {
@@ -305,7 +305,7 @@ export class RemoteTerminalChannelClient implements IPtyHostController {
 		const args: IGetTerminalLayoutInfoArgs = {
 			workspaceId: workspace.id,
 		};
-		return this._channel.call<ITerminalsLayoutInfo>('$getTerminalLayoutInfo', args);
+		return this._channel.call<ITerminalsLayoutInfo>(RemoteTerminalChannelRequest.GetTerminalLayoutInfo, args);
 	}
 
 	reviveTerminalProcesses(workspaceId: string, state: ISerializedTerminalState[], dateTimeFormatLocate: string): Promise<void> {