Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet: support to exclude languages from emmet abbreviation #11283

Closed
egamma opened this issue Aug 31, 2016 · 2 comments
Closed

Emmet: support to exclude languages from emmet abbreviation #11283

egamma opened this issue Aug 31, 2016 · 2 comments
Assignees
Milestone

Comments

@egamma
Copy link
Member

egamma commented Aug 31, 2016

With the new support to infer from the language's grammar's scope ('text.html.markdown') whether emmet should be enabled for a file, emmet is now enabled for more languages, e.g., in markdown files.

There should be support to exclude a list of languages from the emmet abbreviations so that users can get back the old behaviour without having to fully disable emmet.

@mrmlnc what do you think?

@egamma egamma added this to the August 2016 milestone Aug 31, 2016
@egamma egamma self-assigned this Aug 31, 2016
@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 31, 2016

@egamma, I fully agree with you. For example, this behavior would be useful for PHP developers (#7913).

I think that such a possibility should work only with commands when you press Tab.

@egamma
Copy link
Member Author

egamma commented Sep 1, 2016

@mrmlnc

I think that such a possibility should work only with commands when you press Tab.

I agree, but this would require to introduce a separate in addition to ExpandAbbreviation e.g. ExpandAbbreviationOnTab to distinguish this case, An action should not know how it was invoked. This would mean that two actions show up in the Command Palette which is ugly. So let's see what feedback we get first.

@egamma egamma closed this as completed Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants