debug console: broken spacing

[weinand]

• VSCode Version: 1.5 insiders
• OS Version: macOS

The line spacing has changed in the latest:

Here is the spacing in stable:

[isidorn]

@roblourens this was probably introduced by your PR. Do you want to look into to (I can also fix it tomorrow morning)? I think it is not a big issue, we just need to ignore the last '\n' when spliting lines

To repro:

• clone https://github.com/Microsoft/vscode-node-debug
• npm install
• run tests via debug viewlet

[roblourens]

I debugged this and I see that every console.log in node produces an extra line - but the problem is that since the node adapter is listening to logs from stdout, there will be an extra newline at the end. e.g. -

console.log('test') produces an OutputEvent with value 'test\n'. And console.log('test\n') -> 'test\n\n'.

So I assume we should just remove the last newline here https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/nodeDebug.ts#L913 but I also see this line that explicitly adds a newline - do you want all OutputEvents to be newline-terminated?

[isidorn]

@roblourens @weinand since we are wrapping up the release I am fine with also filtering the last new line on the vscode since we were doing that previously. Though the right fix seems to be to handle this on the node debug side imho. Since 'hello' and 'hello\n' should produce different results on the vscode side.
@weinand let me know what you think, maybe I am missing something specified in the protocol

[weinand]

console.log('test') produces a '\n' at the end by definition of log():

Console.prototype.log = function() {
  this._stdout.write(util.format.apply(this, arguments) + '\n');
};

It is not node-debug that introduces any characters.

VS Code should not modify the data received through the OutputEvents in any way.
If a node program decides to use process.stdout.write("test") (which does not append a newline), VS Code should not add a newline on itself.

The best way to verify the behaviour of the debug console is to run a program that produced output both in the debug console and the integrated terminal.

[weinand]

Here is an example that shows the difference:

process.stdout.write("hello");
process.stderr.write("world");

Expected output from Integrated Terminal:

Wrong output in Debug Console:

[isidorn]

That is not a regression so I have created a seperate issue to track this #11376

[roblourens]

Wanted to point this out in case you didn't notice it- I see the extra line fixed between logs, but not between logs and console input:

[octref]

Verified fix by building the latest from master. Here is the output for running tests in vscode-node-debug:

However, it's producing empty lines for strings much shorter than one line length, like for this line:

✓ should stop on a breakpoint in source (all files top level, missing sourceMappingURL) (424ms)

When the window is resized the problem is more severe.

My guess is color code like \033[0;31m are taken into account for counting line-width.

@isidorn

Should I add verified and open this bug as a new issue?

[isidorn]

@octref yes, please add the verified and open the new issue. Good guess, color codes are probably the root cause fo the height measuring issue!

[joaomoreno]

@octref Good guess

[isidorn]

Adding verified instead of @octref just to get this out of our 'to-verify' query today

[octref]

Sorry just see it here. Thanks for adding it. I'll open an issue when I'm in office.