Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug console should compute colored output's length correctly #11467

Closed
octref opened this issue Sep 2, 2016 · 2 comments
Closed

Debug console should compute colored output's length correctly #11467

octref opened this issue Sep 2, 2016 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
Backlog

Comments

@octref
Copy link
Contributor

octref commented Sep 2, 2016

  • VSCode Version: 1.5.0
  • OS Version: OS X 10.11.5

Steps to Reproduce:

  1. Clone https://github.com/Microsoft/vscode-node-debug
  2. npm install && gulp build
  3. Run tests

When going to launch.json and remove --colors from mocha, it works fine:

image

The debug console need to handle color code like \033[0;31m used to color terminal output.

Related to #11321
@octref octref added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 2, 2016
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Sep 5, 2016
@isidorn isidorn added this to the Backlog milestone Sep 5, 2016
@isidorn
Copy link
Contributor

isidorn commented Sep 5, 2016

The code for computing output length is here
I am not jumping on this since we will probably change the underlying implemntation of the debug console #11462

fyi @roblourens

@isidorn
Copy link
Contributor

isidorn commented Nov 25, 2016

This is fixed now

@isidorn isidorn closed this as completed Nov 25, 2016
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@isidorn @octref @ramya-rao-a