Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkspaceConfiguration.update API will remove the existing comments of launch.json #119439

Closed
testforstephen opened this issue Mar 22, 2021 · 3 comments
Closed

WorkspaceConfiguration.update API will remove the existing comments of launch.json #119439

testforstephen opened this issue Mar 22, 2021 · 3 comments
Assignees
@sandy081
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@testforstephen
Copy link

Our Java Debugger uses WorkspaceConfiguration.update API to insert more debug configurations into launch.json, but one problem with this API is that it reformats launch.json and remove the user's comments as well. The reformatting is not a big issue, but remove the existing comments looks like a bug.
@testforstephen testforstephen mentioned this issue Mar 22, 2021
Closed
@sandy081
Copy link
Member

/duplicate

@bersbersbers
Copy link

bersbersbers commented Mar 23, 2021 •
edited
Loading

For anyone following this issue, duplicates are #110295, #99305, #37138 (all also closed as duplicates) and finally #29453.

@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sandy081 @bersbersbers @testforstephen and others