Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test renderer messaging API #125016

Closed
2 tasks done
connor4312 opened this issue Jun 1, 2021 · 3 comments
Closed
2 tasks done

Test renderer messaging API #125016

connor4312 opened this issue Jun 1, 2021 · 3 comments

Comments

@connor4312
Copy link
Member

connor4312 commented Jun 1, 2021

Refs: #123601

Complexity 4

Create Issue


Renderers do not use standard webview messaging, so we created a new messaging channel for them to talk to the extension. Messaging must be requested statically and is opt-in, since renderers which have a hard dependency on messaging will not be usable in aznb.

You can test this functionality with an existing renderer-bearing extension, like github-issues-notebooks, or create your own renderer via npm install -g generator-code && yo code --insiders

@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2021

Link to API to be reviewed: https://github.com/microsoft/vscode/blob/main/src/vs/vscode.proposed.d.ts#L1471
Link to github-issues-notebooks extension (which can be installed to try this out) https://github.com/microsoft/vscode-github-issue-notebooks

@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2021

I reviewed this API and used it very basically. I think it would be more useful if potential clients of the API also provide their real world feedback.

@andreamah
Copy link
Contributor

I also tested it pretty basically in the github-issues-notebook extension, so I agree with the comment above that it would be helpful if potential users are to try it.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants