Generated template for custom notebook renderers won't compile

[andreamah]

Testing #125016

When I generate the template extension code using npm install -g generator-code && yo code --insiders, I get an error in client/index.ts

[andreamah]

Following up on this, there are also some issues with extension/sampleProvider.ts when I download the template including the kernel.

[connor4312]

thanks, looks like several updatees are needed. I recommend using the github-issues-notebook as a sample/starter for verification purposes

[jrieken]

@tanhakabir Where do those template come from?

[tanhakabir]

generator-code, I haven't pushed an update for the serializer/kernel yet since we'll be pushing the API onto stable soon, but the renderer should work. I can check

[connor4312]

@tanhakabir I think you resolved this with the onboarding work last iteration?

[connor4312]

Looks like it microsoft/vscode-generator-code@4da9eda

[TylerLeonhardt]

Looks fixed:

One question... I noticed that it has a main entry point. This isn't needed right? This also blocks the generated extension to be installed on Web because of that main entry point without a browser one.

I think we probably want to either remove the main or add a browser.

[connor4312]

@TylerLeonhardt I think that's a good idea, the trouble is that if the user doesn't have a notebook capable of outputting the given mimetype already then they can't see their renderer. I know we're talking about having a built-in ipynb deserializer, though it looks like that doesn't exist yet. @rebornix is that still the plan? If so we can include a sample.ipynb and know that it'll work.

[rebornix]

I know we're talking about having a built-in ipynb deserializer, though it looks like that doesn't exist yet. @rebornix is that still the plan? If so we can include a sample.ipynb and know that it'll work.

We have the ipynb serialzier shipped with the coming VS Code Stable.

[connor4312]

Oh, sweet! I see it now, I was a couple Insiders behind on my home PC.