Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose API to provide expandable message in notifications #126526

Closed
nelango opened this issue Jun 16, 2021 · 5 comments
Closed

Expose API to provide expandable message in notifications #126526

nelango opened this issue Jun 16, 2021 · 5 comments
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-notifications Notification widget issues

Comments

@nelango
Copy link

nelango commented Jun 16, 2021

Expose API to provide expandable message in notifications (showInformationMessage / showWarningMessage / showErrorMessage ). The API could be something like: showInformationMessage(summaryMessage: string, fullMessage: string, ...items: string[])

Currently, if actions are present in these notification messages, the view is automatically expanded. Instead:

  • minimize it and display a summary message by default
  • make it expandable and display the full message exposed through API when expanded
@bpasero bpasero added api feature-request Request for new features or functionality workbench-notifications Notification widget issues labels Jun 17, 2021
@bpasero bpasero removed their assignment Jun 17, 2021
@bpasero
Copy link
Member

bpasero commented Jun 17, 2021

//cc @jrieken

@jrieken
Copy link
Member

jrieken commented Jun 17, 2021

dupe of #125750?

@bpasero
Copy link
Member

bpasero commented Jun 17, 2021

Yeah maybe, if we end up implementing the new detail option like that for notifications, an extension could use message for the brief variant and add additional content to details. Let's move into that issue, @nelango maybe comment there.

@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @jrieken @nelango and others