-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for details in message options #125750
Comments
@bpasero I am also looking into supporting detail for non-modal messages. I was planning to concat the detail to the message, separated by a new line. However, it seems that newline are being stripped from notifications. Is that on purpose? Any other ideas? |
@jrieken this was mainly to prevent extensions from abusing notifications from showing rich content in notifications. I do not think that notifications are the right widget to show lots of text, specifically because the area to show content is so small. Why not limit |
My worry is that extensions, that want detail, will now use modal dialogs instead of notifications... But I am also fine to wait for that to happen |
Yup, also fine for me. My rationale is that a misbehaving extension that pops up many modal dialogs will get either uninstalled or will start to see lots of issues reported by users as a consequence. Btw if it makes the API any easier, we could still allow |
Append how? I tried the newline separation which didn't work. I don't think that we can use dot or something else |
Yeah just literally on the extension host even, concatenating the message + detail. It needs some heuristics I guess, e.g. if message does not end with a |
Based on @mjbvz suggestion: showing "More" which shows details in a modal Screen.Recording.2021-06-16.at.15.06.43.mov |
Interesting idea, should probably discuss in a UX call. I am not sure how obvious it is what "More" means in the context alongside the other buttons (because they are all in the same hierarchy). And then in the modal dialog it maybe less obvious that only the details are showing. cc @misolori |
Decision is to not support |
To verify use the yeoman extension sample and add |
The MessageOptions-type allows to tweak the behavior
showInformationMessage
and friends. We should also allow for adetails
property which are then rendered nicer for modal dialogs.The text was updated successfully, but these errors were encountered: