Questionable implementation of getProcessId

[bpasero]

Testing #12595

See https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHostTerminalService.ts#L44

public get processId(): Thenable<number> {
    this._checkDisposed();
    if (this._processId) {
        return Promise.resolve<number>(this._processId);
    }
    setTimeout(() => {
        return this.processId;
    }, 200);
}

First of all, if you reach the setTimeout, there is no return value after all (just undefined). And then, how do you know that the process id is there after 200ms?

[Tyriar]

Inside the promise it recurses as it returns the getter not the backing value, I was planning on removing the setTimeout in October #12434

Fixing the bug now though.

[bpasero]

And the 200ms is just a guess?

[Tyriar]

Yes, it likely only needs much less than that thought. I'll improve it in October.