Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notebook renderer sample to use the builtin ipynb #129982

Closed
connor4312 opened this issue Aug 2, 2021 · 5 comments
Closed

Update notebook renderer sample to use the builtin ipynb #129982

connor4312 opened this issue Aug 2, 2021 · 5 comments
Assignees
@rebornix @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug notebook polish Cleanup and polish issue verified Verification succeeded
Milestone
August 2021

Comments

@connor4312
Copy link
Member

Looks fixed:

image

One question... I noticed that it has a main entry point. This isn't needed right? This also blocks the generated extension to be installed on Web because of that main entry point without a browser one.

I think we probably want to either remove the main or add a browser.

Originally posted by @TylerLeonhardt in #125196 (comment)
@connor4312 connor4312 self-assigned this Aug 2, 2021
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug notebook polish Cleanup and polish issue labels Aug 2, 2021
@connor4312 connor4312 added this to the August 2021 milestone Aug 2, 2021
@rzhao271
Copy link
Contributor

What are some verification steps for this issue?

@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Aug 26, 2021
@connor4312
Copy link
Member Author

Use the latest yo code to create a notebook renderer. Verify that the sample works, and only contains renderer (not extension host) code.

@connor4312 connor4312 removed the verification-steps-needed Steps to verify are needed for verification label Aug 26, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 26, 2021
@rzhao271
Copy link
Contributor

I still see an extension folder get generated after updating yo and generator-code.
Does a new package need to be published? https://www.npmjs.com/package/generator-code

@rzhao271 rzhao271 reopened this Aug 26, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Aug 26, 2021
@connor4312
Copy link
Member Author

Published, should be out momentarily

@connor4312 connor4312 removed the verification-found Issue verification failed label Aug 26, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug notebook polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
4 participants
@rebornix @connor4312 @rzhao271 and others