Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug-continue icon is bolder than others #133293

Closed
roblourens opened this issue Sep 16, 2021 · 6 comments
Closed

debug-continue icon is bolder than others #133293

roblourens opened this issue Sep 16, 2021 · 6 comments
Assignees
Labels
notebook ux User experience issues
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Sep 16, 2021

@misolori we are trying to use the debug-continue icon for a button in the cell toolbar, but it has a more bold appearance than other icons. It seems like this is probably just on purpose because all the debug icons are colored and look nice with bold lines. But it might mean that we can't reuse them in other places. Or it might be fine. What do you think?

image

cc @DavidKutu

@DavidKutu
Copy link

I'd prefer it not being bold.

@roblourens
Copy link
Member Author

I think it's ok for now, gonna move it off Sept, but let me know if you have any ideas @misolori

@roblourens roblourens modified the milestones: September 2021, Backlog Sep 24, 2021
@miguelsolorio
Copy link
Contributor

I can add a less bold version for each of the debug icons? Or should it just be continue?

@roblourens
Copy link
Member Author

That would help. I only plan to use continue

@miguelsolorio
Copy link
Contributor

Ok we now have debug-continue-small that we can use the uses the regular 1px stroke:

image

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @rebornix @DavidKutu @miguelsolorio and others