Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime API to disable user activation per frame per origin #140106

Open
Tyriar opened this issue Jan 4, 2022 · 2 comments
Open

Runtime API to disable user activation per frame per origin #140106

Tyriar opened this issue Jan 4, 2022 · 2 comments
Assignees
@deepak1556
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-os-integration Native OS integration issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2022

The terminal ligatures exploration in #139537 ended up hitting an issue where Electron now requires a user activation in order to read ligatures, even when ligatures bypass the permissions prompt/handler. This is a blocker to get terminal ligatures working, at least without something hacky like piggybacking on the next user activation event.

IMO Electron should allow disabling the user activation requirement outright, potentially automatically when the permissions dialog will be bypassed?
@Tyriar Tyriar mentioned this issue Jan 4, 2022
Closed
8 tasks
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron workbench-os-integration Native OS integration issues labels Dec 7, 2022
@deepak1556
Copy link
Collaborator

@Tyriar do you still need this feature from the runtime ?

@deepak1556 deepak1556 added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Dec 12, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Dec 12, 2023 •
edited
Loading

Yes I think this still blocks terminal ligatures

@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Dec 12, 2023
@deepak1556 deepak1556 changed the title "SecurityError: User activation is required" when querying font access API Runtime API to disable user activation per frame per origin Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-os-integration Native OS integration issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deepak1556 @Tyriar